DFBUGS-925: [release-4.18] controllers: new controller for maintenance mode #280
Conversation
Signed-off-by: Rewant Soni <[email protected]>
|
@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: openshift-ci-robot. Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retitle DFBUGS-925: [release-4.18] controllers: new controller for maintenance mode |
openshift-ci
bot
changed the title
|
@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@rewantsoni: This pull request references [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@rewantsoni: This pull request references [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925), which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold did you try updating to this PR w/ 4.17 build? I believe olm stops CRD change when new field is introduced w/ required qualifier 🤔. Let me recheck as well. Edit: I think similar thing happened w/ https://github.ibm.com/lgangava/forge/blob/main/2024-06-07/main.py#L815 |
|
/unhold |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@rewantsoni: This pull request references [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925), which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@Nikhil-Ladha: This pull request references [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925), which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle [release-4.18] controllers: new controller for maintenance mode |
openshift-ci
bot
changed the title
|
/retitle DFBUGS-925: [release-4.18] controllers: new controller for maintenance mode |
openshift-ci
bot
changed the title
|
/retitle DFBUGS-925: [release-4.18] controllers: new controller for maintenance mode |
|
/jira refresh |
|
@rewantsoni: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle [DFBUGS-925]: [release-4.18] controllers: new controller for maintenance mode |
openshift-ci
bot
changed the title
Nikhil-Ladha
changed the title
|
@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925), which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Nikhil-Ladha
added
the
jira/valid-bug
openshift-merge-bot
bot
merged commit c22cf93
into
red-hat-storage:release-4.18
|
@openshift-cherrypick-robot: [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925): All pull requests linked via external trackers have merged: [Jira Issue DFBUGS-925](https://issues.redhat.com//browse/DFBUGS-925) has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is an automated cherry-pick of #264
/assign openshift-ci-robot