Create new test file for testing resize OSD #9583

yitzhak12 · 2024-03-28T18:16:23Z

The PR implements the basic test scenario of the resize osd feature. For more details about the feature, see https://issues.redhat.com/browse/RHSTOR-5251, and for the test details, see the test plan spreadsheet: https://docs.google.com/spreadsheets/d/1wCSwMk_L4SikzZ2UarUH1-VCXyGkHs-ZNdDEtWPG7f4/edit#gid=105186681&range=B8.
In the test, we will perform the following:

Prepare all the relevant data before the resizing(Save the old pods, PVCs, PVs, create pods and PVCs and run IO, save the file md5sum).
Resize the osd by multiplying 2(This will be done by patching the storagecluster storage param).
Check that the resources are in the expected state and that the new size is reflected in the resources and Ceph. Also, check that the md5sum of the files didn't change after the resize osd.
Check the cluster and Ceph health

ocs-ci

PR validation on existing cluster

Cluster Name: ikave-aws416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_resize_osd.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

ocs-ci

PR validation on existing cluster

Cluster Name: ikave-aws416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_resize_osd.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

fbalak

The functionality looks good but I have 2 suggestions:

New *post_resize_osd functions shouldn't be in cluster.py module in my opinion. It would be better to have a new module (e.g. osd_resize.py) that would contain those checks and resize functionality. Some of those functions use storagecluster cr but their functionality is focused on osds and resizing.
It is better to raise an Exception in module function instead of assert. Asserts should be used in tests but functions that could be reused on multiple places should raise an Exception that can be handled (e.g. negative scenario where you want it to fail).

yitzhak12 · 2024-04-09T10:44:05Z

Thanks @fbalak. I will modify the code accordingly.

- Create new Plarion test case - Create new file for the resize osd functions - Raise excpetion intead of assert in the relevant two functions Signed-off-by: Itzhak Kave <[email protected]>

ocs-ci

PR validation on existing cluster

Cluster Name: ikave-ibm416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_resize_osd.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci

PR validation on existing cluster

Cluster Name: ikave-ibm416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_resize_osd.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

ebenahar · 2024-04-10T14:30:23Z

ocs_ci/ocs/resources/osd_resize.py

+
+    logger.info(
+        f"Check that the number of the new OSD pods are exactly {old_osd_pods_count}"
+    )


can we also add a validation that the Running OSD pod names are different than old_osd_pods names?

Yes, I can add it.

ocs_ci/ocs/resources/osd_resize.py

ebenahar · 2024-04-10T14:45:41Z

ocs_ci/ocs/resources/storage_cluster.py

+        bool: True in case if changes are applied. False otherwise
+
+    """
+    sc = get_storage_cluster()


please add a check that the new requested size is greater than the existing OSD size.
And should we add a test case of tyring to resize to a smaller size?

Okay, np.
We added a negative test in the test plan: https://docs.google.com/spreadsheets/d/1wCSwMk_L4SikzZ2UarUH1-VCXyGkHs-ZNdDEtWPG7f4/edit#gid=105186681&range=B24

do you plan to add it in a follow up PR?

I have implemented the osd size check.
I will add the negative test in another PR. I need to check first manually what is the behavior

… validation check for the 'resize_osd' function Signed-off-by: Itzhak Kave <[email protected]>

ocs-ci

PR validation on existing cluster

Cluster Name: ikave-ibm416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_resize_osd.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

…ze 1024 Signed-off-by: Itzhak Kave <[email protected]>

Signed-off-by: Itzhak Kave <[email protected]>

ocs-ci

PR validation on existing cluster

Cluster Name: ikave-aws416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_resize_osd.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

openshift-ci · 2024-04-15T11:00:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar, fbalak, yitzhak12

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

petr-balogh · 2024-04-16T15:01:53Z

If this PR is going to be cherry-picked we need to include fix from Vijay:
#9678

As this code braking the add capacity test:

>       device_sets_required = int(osd_size_capacity_requested / osd_size_existing)
E       TypeError: unsupported operand type(s) for /: 'str' and 'str'

ocs_ci/ocs/resources/storage_cluster.py:1470: TypeError

@yitzhak12 FYI

yitzhak12 requested a review from a team as a code owner March 28, 2024 18:16

pull-request-size bot added the size/L PR that changes 100-499 lines label Mar 28, 2024

openshift-merge-robot added the needs-rebase label Mar 28, 2024

yitzhak12 added the do-not-merge/work-in-progress label Mar 28, 2024

yitzhak12 force-pushed the test-resize-osd branch from 8f8ca79 to 24f62e2 Compare April 2, 2024 16:25

openshift-merge-robot removed the needs-rebase label Apr 2, 2024

yitzhak12 force-pushed the test-resize-osd branch from 24f62e2 to 7d3b349 Compare April 3, 2024 17:17

pull-request-size bot added size/XL and removed size/L PR that changes 100-499 lines labels Apr 3, 2024

yitzhak12 force-pushed the test-resize-osd branch from 7d3b349 to 7bc8b79 Compare April 4, 2024 10:51

yitzhak12 changed the title ~~Test resize OSD~~ Create new test file for testing resize OSD Apr 4, 2024

openshift-ci bot removed the do-not-merge/work-in-progress label Apr 4, 2024

yitzhak12 force-pushed the test-resize-osd branch from 7bc8b79 to 6270c3a Compare April 4, 2024 11:14

ocs-ci reviewed Apr 4, 2024

View reviewed changes

yitzhak12 force-pushed the test-resize-osd branch from 6270c3a to 14956f1 Compare April 4, 2024 13:00

yitzhak12 added the Squad/Brown label Apr 4, 2024

yitzhak12 force-pushed the test-resize-osd branch 2 times, most recently from 5ba4964 to ba8c2f9 Compare April 4, 2024 14:32

yitzhak12 added the Verified Mark when PR was verified and log provided label Apr 4, 2024

yitzhak12 force-pushed the test-resize-osd branch 2 times, most recently from 6b1af11 to e3b904b Compare April 7, 2024 14:48

ocs-ci reviewed Apr 7, 2024

View reviewed changes

fbalak reviewed Apr 9, 2024

View reviewed changes

yitzhak12 requested a review from a team as a code owner April 10, 2024 09:08

openshift-merge-robot added the needs-rebase label Apr 10, 2024

- Create the resize osd test and the verification steps

21101de

- Create new Plarion test case - Create new file for the resize osd functions - Raise excpetion intead of assert in the relevant two functions Signed-off-by: Itzhak Kave <[email protected]>

yitzhak12 force-pushed the test-resize-osd branch from f207853 to 21101de Compare April 10, 2024 10:30

openshift-merge-robot removed the needs-rebase label Apr 10, 2024

ocs-ci reviewed Apr 10, 2024

View reviewed changes

ebenahar added the Test Case A test case PR label Apr 10, 2024

ocs-ci reviewed Apr 10, 2024

View reviewed changes

ebenahar reviewed Apr 10, 2024

View reviewed changes

Check that the new osd pod names are different than the old ones, add…

0f34a38

… validation check for the 'resize_osd' function Signed-off-by: Itzhak Kave <[email protected]>

yitzhak12 force-pushed the test-resize-osd branch from ae98146 to 0f34a38 Compare April 11, 2024 12:36

ocs-ci reviewed Apr 11, 2024

View reviewed changes

Get the storage size, PVC size, and PV size in GB with the convert si…

5898af6

…ze 1024 Signed-off-by: Itzhak Kave <[email protected]>

ebenahar previously approved these changes Apr 14, 2024

View reviewed changes

openshift-ci bot assigned ebenahar Apr 14, 2024

openshift-ci bot added the lgtm label Apr 14, 2024

Remove a redundant line

2b6a77b

Signed-off-by: Itzhak Kave <[email protected]>

yitzhak12 dismissed ebenahar’s stale review via 2b6a77b April 14, 2024 11:31

openshift-ci bot removed the lgtm label Apr 14, 2024

ocs-ci reviewed Apr 14, 2024

View reviewed changes

ebenahar approved these changes Apr 14, 2024

View reviewed changes

openshift-ci bot added the lgtm label Apr 14, 2024

fbalak approved these changes Apr 15, 2024

View reviewed changes

openshift-ci bot assigned fbalak Apr 15, 2024

ebenahar merged commit 250a228 into red-hat-storage:master Apr 15, 2024
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create new test file for testing resize OSD #9583

Create new test file for testing resize OSD #9583

yitzhak12 commented Mar 28, 2024 •

edited

Loading

ocs-ci left a comment

ocs-ci left a comment

fbalak left a comment

yitzhak12 commented Apr 9, 2024

ocs-ci left a comment

ocs-ci left a comment

ebenahar Apr 10, 2024

yitzhak12 Apr 10, 2024

yitzhak12 Apr 11, 2024

ebenahar Apr 10, 2024

yitzhak12 Apr 10, 2024

ebenahar Apr 11, 2024

yitzhak12 Apr 11, 2024

ocs-ci left a comment

ocs-ci left a comment

openshift-ci bot commented Apr 15, 2024

petr-balogh commented Apr 16, 2024

Create new test file for testing resize OSD #9583

Create new test file for testing resize OSD #9583

Conversation

yitzhak12 commented Mar 28, 2024 • edited Loading

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

fbalak left a comment

Choose a reason for hiding this comment

yitzhak12 commented Apr 9, 2024

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ebenahar Apr 10, 2024

Choose a reason for hiding this comment

yitzhak12 Apr 10, 2024

Choose a reason for hiding this comment

yitzhak12 Apr 11, 2024

Choose a reason for hiding this comment

ebenahar Apr 10, 2024

Choose a reason for hiding this comment

yitzhak12 Apr 10, 2024

Choose a reason for hiding this comment

ebenahar Apr 11, 2024

Choose a reason for hiding this comment

yitzhak12 Apr 11, 2024

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

ocs-ci left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Apr 15, 2024

petr-balogh commented Apr 16, 2024

yitzhak12 commented Mar 28, 2024 •

edited

Loading