Skip to content

Commit

Permalink
Check that the new osd pod names are different than the old ones, add…
Browse files Browse the repository at this point in the history
… validation check for the 'resize_osd' function

Signed-off-by: Itzhak Kave <[email protected]>
  • Loading branch information
Itzhak Kave committed Apr 11, 2024
1 parent 8838210 commit ae98146
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion ocs_ci/ocs/resources/osd_resize.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def check_resources_state_post_resize_osd(old_osd_pods, old_osd_pvcs, old_osd_pv
old_name_set = {p.name for p in old_osd_pods}
if new_name_set.intersection(old_name_set):
raise ResourceWrongStatusException(
f"There are common values between the new osd pod names and the old osd pod names. "
f"There are shared values between the new osd pod names and the old osd pod names. "
f"old osd pod names = {old_name_set}, new osd pod names = {new_name_set}"
)

Expand Down
1 change: 0 additions & 1 deletion ocs_ci/ocs/resources/storage_cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -2711,7 +2711,6 @@ def resize_osd(new_osd_size, check_size=True):
f"current osd size {current_osd_size}"
)

return True
sc = get_storage_cluster()
# Patch the OSD storage size
path = "/spec/storageDeviceSets/0/dataPVCTemplate/spec/resources/requests/storage"
Expand Down

0 comments on commit ae98146

Please sign in to comment.