Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provision for installing submariner downstream unreleased build #8716
Provision for installing submariner downstream unreleased build #8716
Changes from 9 commits
6cd4525
caa7b81
689db13
bd7f883
e2e87ce
c9ed0a1
2ddc236
80e4fec
a890fa4
2bc663a
c5f35dc
8a5356f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain default value for enable_globalnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we support only one specific unreleased DS version? Or we do support also previous unreleased DS versions, like we do in ODF? E.g.
4.13.5
.If so , then maybe we can move to the ODF or OCP configuration file - depends on to which is's more relevant.
If only one unreleased version, we can keep it here in the file. She same Q for the channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keesturam , @prsurve @sidhant-agrawal , could you please provide your inputs here so that we can create OCP/ODF specific submariner versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ODF's y stream releases, we will mostly support one unreleased submariner version until GA. However, after the GA we will have to support future versions.
For eg., all the while with 4.14, we have been using submariner 0.16.0.
I hope this helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.