Provision for installing submariner downstream unreleased build #8716

shylesh · 2023-10-19T19:47:45Z

No description provided.

shylesh · 2023-10-23T08:44:24Z

Rebased on latest master

conf/ocsci/enable_globalnet.yaml

conf/ocsci/submariner_downstream_unreleased.yaml

ocs_ci/deployment/acm.py

ocs_ci/ocs/acm/acm.py

ocs_ci/templates/ocs-deployment/multicluster/submariner_downstream_unreleased_catsrc.yaml

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

shylesh · 2023-10-26T09:49:23Z

Rebased on latest master

Simplify build tag extraction for submariner Signed-off-by: Shylesh Kumar Mohan <[email protected]>

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

ocs_ci/templates/acm-deployment/acm_downstream_brew_icsp.yaml

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

petr-balogh · 2023-11-01T10:04:20Z

ocs_ci/deployment/deployment.py

@@ -351,6 +352,43 @@ def do_deploy_ocs(self):
                            "ocs_registry_image", None
                        )
                        ocs_install_verification(ocs_registry_image=ocs_registry_image)
+                # if we have Globalnet enabled in case of submariner with RDR
+                # we need to add a flag to storagecluster
+                if config.ENV_DATA.get("enable_globalnet", None):


Suggested change

if config.ENV_DATA.get("enable_globalnet", None):

if config.ENV_DATA.get("enable_globalnet", True):

petr-balogh · 2023-11-01T10:33:46Z

conf/ocsci/submariner_downstream_unreleased.yaml

+ENV_DATA:
+  submariner_source: "downstream"
+  submariner_release_type: "unreleased"
+  submariner_version: "0.16.0"


Do we support only one specific unreleased DS version? Or we do support also previous unreleased DS versions, like we do in ODF? E.g. 4.13.5.

If so , then maybe we can move to the ODF or OCP configuration file - depends on to which is's more relevant.
If only one unreleased version, we can keep it here in the file. She same Q for the channel.

@keesturam , @prsurve @sidhant-agrawal , could you please provide your inputs here so that we can create OCP/ODF specific submariner versions?

For ODF's y stream releases, we will mostly support one unreleased submariner version until GA. However, after the GA we will have to support future versions.
For eg., all the while with 4.14, we have been using submariner 0.16.0.
I hope this helps.

conf/README.md

ocs_ci/deployment/deployment.py

Validation for serviceexports Addressed few review comments Signed-off-by: Shylesh Kumar Mohan <[email protected]>

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

shylesh · 2023-11-06T18:26:46Z

Verified here: https://url.corp.redhat.com/rdrglobalnetverification

conf/ocsci/enable_globalnet.yaml

conf/ocsci/submariner_downstream_unreleased.yaml

shylesh · 2023-10-27T14:00:52Z

conf/README.md

@@ -256,6 +256,10 @@ higher priority).
 * `nb_nfs_mount` - NFS mount point used specifically for testing noobaa db NFS mount test
 * `custom_default_storageclass_names` - Set to true if custom storageclass names use instead of default one.
 * `storageclassnames` - Under this key, custom storage class names for `cephFilesystems`, `cephObjectStores`, `cephBlockPools`, `cephNonResilientPools`, `nfs` and for `encryption` are defined.
+* `submariner_source` - Source from which we take submariner build, ex: upstream, downstream, downstream_unreleased
+* `submariner_release_type` - Released OR Unreleased submariner build
+* `enable_globalnet` - enable or disable globalnet for submariner


explain default value for enable_globalnet

ocs_ci/templates/acm-deployment/acm_downstream_brew_icsp.yaml

shylesh · 2023-11-01T17:40:37Z

conf/ocsci/submariner_downstream_unreleased.yaml

+ENV_DATA:
+  submariner_source: "downstream"
+  submariner_release_type: "unreleased"
+  submariner_version: "0.16.0"


@keesturam , @prsurve @sidhant-agrawal , could you please provide your inputs here so that we can create OCP/ODF specific submariner versions?

conf/README.md

ocs_ci/deployment/deployment.py

conf/README.md

openshift-ci · 2023-11-07T10:31:20Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: am-agrawa, petr-balogh, prsurve, shylesh, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shylesh requested a review from a team as a code owner October 19, 2023 19:47

openshift-ci bot added the do-not-merge/work-in-progress label Oct 19, 2023

pull-request-size bot added the size/L PR that changes 100-499 lines label Oct 19, 2023

shylesh added DR Metro and Regional DR related PRs team/ecosystem Ecosystem team related issues/PRs labels Oct 19, 2023

shylesh force-pushed the submariner-unreleased-downstream branch from 4c5cbd0 to 6f1b21f Compare October 19, 2023 19:52

shylesh self-assigned this Oct 20, 2023

shylesh requested a review from a team as a code owner October 20, 2023 20:57

shylesh force-pushed the submariner-unreleased-downstream branch from ead53ef to 869c8bd Compare October 23, 2023 08:44

shylesh changed the title ~~WIP: Provision for installing submariner downstream unreleased build~~ Provision for installing submariner downstream unreleased build Oct 24, 2023

openshift-ci bot removed the do-not-merge/work-in-progress label Oct 24, 2023

shylesh added the Needs Testing Run tests and provide logs link label Oct 24, 2023

shylesh force-pushed the submariner-unreleased-downstream branch from 402a9b3 to aa1509a Compare October 24, 2023 13:19

petr-balogh reviewed Oct 25, 2023

View reviewed changes

shylesh force-pushed the submariner-unreleased-downstream branch 4 times, most recently from 4c5ba73 to c21d921 Compare October 26, 2023 09:10

shylesh added 4 commits October 26, 2023 10:48

Provision for installing submariner downstream unreleased build

6cd4525

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

Handle UI part of unreleased submariner info

caa7b81

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

Add globalnet flag with default enabled

689db13

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

Update StorageCluster based on globalnet flag

bd7f883

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

shylesh force-pushed the submariner-unreleased-downstream branch from c21d921 to 9364544 Compare October 26, 2023 09:49

Address few more review comments by Petr

e2e87ce

Simplify build tag extraction for submariner Signed-off-by: Shylesh Kumar Mohan <[email protected]>

shylesh force-pushed the submariner-unreleased-downstream branch from 9364544 to e2e87ce Compare October 26, 2023 11:30

shylesh added 3 commits October 26, 2023 17:31

replace oc apply with oc patch for global net updates

c9ed0a1

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

Add ocs install verification after patching storagecluster

2ddc236

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

Fix flake8 failures

80e4fec

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

petr-balogh previously approved these changes Oct 27, 2023

View reviewed changes

openshift-ci bot assigned petr-balogh Oct 27, 2023

openshift-ci bot added the lgtm label Oct 27, 2023

dahorak previously approved these changes Oct 27, 2023

View reviewed changes

openshift-ci bot assigned dahorak Oct 27, 2023

prsurve reviewed Oct 30, 2023

View reviewed changes

ocs_ci/templates/acm-deployment/acm_downstream_brew_icsp.yaml Outdated Show resolved Hide resolved

Update enable_globalnet flag to be defaut false

2bc663a

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

shylesh dismissed stale reviews from dahorak and petr-balogh via 2bc663a October 31, 2023 17:08

openshift-ci bot removed the lgtm label Oct 31, 2023

petr-balogh reviewed Nov 1, 2023

View reviewed changes

sidhant-agrawal reviewed Nov 2, 2023

View reviewed changes

conf/README.md Outdated Show resolved Hide resolved

sidhant-agrawal reviewed Nov 2, 2023

View reviewed changes

ocs_ci/deployment/deployment.py Show resolved Hide resolved

Move submariner_version parameter to ocp version specific files

c5f35dc

Validation for serviceexports Addressed few review comments Signed-off-by: Shylesh Kumar Mohan <[email protected]>

shylesh force-pushed the submariner-unreleased-downstream branch from 7c420de to 125b1bf Compare November 6, 2023 13:19

Add retries to service export validation

8a5356f

Signed-off-by: Shylesh Kumar Mohan <[email protected]>

shylesh force-pushed the submariner-unreleased-downstream branch from 125b1bf to 8a5356f Compare November 6, 2023 15:37

prsurve approved these changes Nov 7, 2023

View reviewed changes

openshift-ci bot assigned prsurve Nov 7, 2023

openshift-ci bot added the lgtm label Nov 7, 2023

sidhant-agrawal approved these changes Nov 7, 2023

View reviewed changes

openshift-ci bot assigned sidhant-agrawal Nov 7, 2023

shylesh commented Nov 7, 2023

View reviewed changes

petr-balogh approved these changes Nov 7, 2023

View reviewed changes

am-agrawa approved these changes Nov 7, 2023

View reviewed changes

openshift-ci bot assigned am-agrawa Nov 7, 2023

petr-balogh merged commit 6f459a8 into red-hat-storage:master Nov 7, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provision for installing submariner downstream unreleased build #8716

Provision for installing submariner downstream unreleased build #8716

shylesh commented Oct 19, 2023

shylesh commented Oct 23, 2023

shylesh commented Oct 26, 2023

petr-balogh Nov 1, 2023

petr-balogh Nov 1, 2023

shylesh Nov 1, 2023

keesturam Nov 2, 2023

shylesh commented Nov 6, 2023

shylesh Oct 27, 2023

shylesh Oct 31, 2023

shylesh Nov 1, 2023

openshift-ci bot commented Nov 7, 2023

	if config.ENV_DATA.get("enable_globalnet", None):
	if config.ENV_DATA.get("enable_globalnet", True):

Provision for installing submariner downstream unreleased build #8716

Provision for installing submariner downstream unreleased build #8716

Conversation

shylesh commented Oct 19, 2023

shylesh commented Oct 23, 2023

shylesh commented Oct 26, 2023

petr-balogh Nov 1, 2023

Choose a reason for hiding this comment

petr-balogh Nov 1, 2023

Choose a reason for hiding this comment

shylesh Nov 1, 2023

Choose a reason for hiding this comment

keesturam Nov 2, 2023

Choose a reason for hiding this comment

shylesh commented Nov 6, 2023

shylesh Oct 27, 2023

Choose a reason for hiding this comment

shylesh Oct 31, 2023

Choose a reason for hiding this comment

shylesh Nov 1, 2023

Choose a reason for hiding this comment

openshift-ci bot commented Nov 7, 2023