Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename restic pods selector to 'node-agent' #8561

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Rename restic pods selector to 'node-agent' #8561

merged 6 commits into from
Oct 16, 2023

Conversation

shylesh
Copy link
Contributor

@shylesh shylesh commented Sep 24, 2023 •
edited
Loading

Based on latest changes to changes from OADP1.1 to 1.2
Fixes #8554

@shylesh shylesh requested a review from a team as a code owner September 24, 2023 20:58
@vavuthu vavuthu added the team/ecosystem Ecosystem team related issues/PRs label Sep 25, 2023
vavuthu
vavuthu previously approved these changes Sep 25, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Sep 25, 2023
dahorak
dahorak previously approved these changes Sep 25, 2023
View reviewed changes
parikshithb
parikshithb reviewed Sep 25, 2023
View reviewed changes
ocs_ci/deployment/deployment.py Outdated
restic_list = get_pods_having_label(
"name=restic", constants.ACM_HUB_BACKUP_NAMESPACE
"name=node-agent", constants.ACM_HUB_BACKUP_NAMESPACE
Copy link
Contributor

@parikshithb parikshithb Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shylesh, this needs to be conditionally handled based on OADP version present on hub.
Changes from OADP 1.1 to 1.2: https://github.com/mateusoliveira43/oadp-operator/blob/fix/remove-1.1-leftovers/docs/upgrade1-1.md#changes-from-oadp-11-to-12

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, sorry, I missed it
I will update it.

@shylesh shylesh dismissed stale reviews from dahorak and vavuthu via aa048d3 September 29, 2023 09:59
@openshift-ci openshift-ci bot removed the lgtm label Sep 29, 2023
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Sep 29, 2023
@shylesh shylesh force-pushed the rename-resticpods branch 2 times, most recently from da01958 to 1a7ee78 Compare September 29, 2023 11:11
@shylesh shylesh added the DR Metro and Regional DR related PRs label Oct 2, 2023
@shylesh shylesh force-pushed the rename-resticpods branch from 1a7ee78 to a9cb624 Compare October 2, 2023 14:39
@shylesh
Copy link
Contributor Author

shylesh commented Oct 2, 2023

Rebased on latest master

@shylesh shylesh force-pushed the rename-resticpods branch from 8ef7288 to 8df67b6 Compare October 3, 2023 10:15
@shylesh
Copy link
Contributor Author

shylesh commented Oct 3, 2023

Rebased on the latest master

@shylesh shylesh force-pushed the rename-resticpods branch from 8df67b6 to fce517a Compare October 4, 2023 19:05
@shylesh
Copy link
Contributor Author

shylesh commented Oct 4, 2023

Rebased on latest master

parikshithb
parikshithb previously approved these changes Oct 6, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Oct 6, 2023
@openshift-ci openshift-ci bot removed the lgtm label Oct 11, 2023
@shylesh
Copy link
Contributor Author

shylesh commented Oct 11, 2023

Rebased on latest master

@shylesh
Copy link
Contributor Author

shylesh commented Oct 14, 2023

https://url.corp.redhat.com/resticpodfix

@shylesh
Rename restic pods selector to 'node-agent'
c4028e9 
Signed-off-by: Shylesh Kumar Mohan <[email protected]>
@shylesh
Handle OADP versions specific pod names
0601564 
Signed-off-by: Shylesh Kumar Mohan <[email protected]>
@shylesh
Fix output redirection issues
9af2cdb 
Signed-off-by: Shylesh Kumar Mohan <[email protected]>
@shylesh
Fix oadp-operator version fetch issue
9d4e487 
Signed-off-by: Shylesh Kumar Mohan <[email protected]>
@shylesh
Fix merge conflicts
cba2897 
Signed-off-by: Shylesh Kumar Mohan <[email protected]>
@shylesh shylesh added the Verified Mark when PR was verified and log provided label Oct 14, 2023
am-agrawa
am-agrawa previously approved these changes Oct 16, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2023
@shylesh
Simplify version extraction
d5e3472 
Signed-off-by: Shylesh Kumar Mohan <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Oct 16, 2023
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines and removed size/M PR that changes 30-99 lines labels Oct 16, 2023
@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, parikshithb, shylesh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shylesh
Copy link
Contributor Author

shylesh commented Oct 16, 2023

https://url.corp.redhat.com/resticpodverified

@shylesh shylesh merged commit 6953a93 into red-hat-storage:master Oct 16, 2023
4 checks passed
@parikshithb parikshithb mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parikshithb parikshithb parikshithb approved these changes

@dahorak dahorak dahorak approved these changes

@am-agrawa am-agrawa am-agrawa left review comments

@vavuthu vavuthu vavuthu left review comments

Assignees

@dahorak dahorak

@parikshithb parikshithb

@vavuthu vavuthu

@am-agrawa am-agrawa

Labels
DR Metro and Regional DR related PRs lgtm size/S PR that changes 10-29 lines team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restic pod count mismatch on ACM 2.9
5 participants
@shylesh @dahorak @parikshithb @vavuthu @am-agrawa