Fix output redirection issues

Signed-off-by: Shylesh Kumar Mohan <[email protected]>
red-hat-storage · Oct 3, 2023 · 8ef7288 · 8ef7288
1 parent a9cb624
commit 8ef7288
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/ocs_ci/utility/utils.py b/ocs_ci/utility/utils.py
@@ -4451,7 +4451,11 @@ def get_oadp_version():
     for csv in csv_list:
         if "oadp-operator" in csv:
             # extract version string
-            cmd = f"oc get csv/{csv} -n {constants.ACM_HUB_BACKUP_NAMESPACE} -o wide | awk {{'print $4'}}"
-            p = subprocess.Popen(cmd, stdout=subprocess.PIPE, shell=True)
-            out = p.communicate()
-            return out[0].splitlines[1].decode()
+            cmd = f"oc get csv/{csv} -n {constants.ACM_HUB_BACKUP_NAMESPACE} -o wide "
+            awk_cmd = "awk {{'print $4'}}"
+            p = subprocess.Popen(shlex.split(cmd), stdout=subprocess.PIPE)
+            outbuf = subprocess.Popen(
+                shlex.split(awk_cmd), stdin=p.stdout, stdout=subprocess.PIPE
+            )
+            out = outbuf.communicate()
+            return out[0].splitlines()[1].decode()