Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translation for option component #368

Merged
merged 18 commits into from
May 26, 2023

Conversation

aroyan
Copy link
Contributor

@aroyan aroyan commented Apr 28, 2023

Related to #330

Closes #424

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@aroyan aroyan changed the title translation for option component docs: translation for option component Apr 28, 2023
Copy link
Collaborator

@mazipan mazipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tinggal nunggu soal caveat aja nih yang masih rancu, overall okay dariku

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halo mas @aroyan, please take a look at these requested changes:

src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
@aroyan
Copy link
Contributor Author

aroyan commented May 1, 2023

Halo mas @aroyan, please take a look at these requested changes:

Sure, it's updated now

@github-actions
Copy link

github-actions bot commented May 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mazipan
Copy link
Collaborator

mazipan commented May 8, 2023

Asking peer review @r17x @mhaidarhanif @zainfathoni.
Also wait for @resir014 approval.

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change.

src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aroyan Outside of @mhaidarhanif's suggestion, all good. Please make the necessary changes.

@aroyan
Copy link
Contributor Author

aroyan commented May 23, 2023

@aroyan Outside of @mhaidarhanif's suggestion, all good. Please make the necessary changes.

@mhaidarhanif @resir014 updated to original values

@resir014 resir014 requested a review from mhaidarhanif May 24, 2023 06:15
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. @mhaidarhanif please review again.

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final tiny details to improve

src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, approved 👍

@mhaidarhanif mhaidarhanif merged commit 31b03ea into reactjs:main May 26, 2023
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
Co-authored-by: Resi Respati <[email protected]>
Co-authored-by: M Haidar Hanif <[email protected]>
Co-authored-by: Irfan Maulana <[email protected]>
Co-authored-by: Zain Fathoni <[email protected]>
@aroyan aroyan deleted the docs/translation/reference/react-dom branch August 2, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<option>
5 participants