-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: translation for option
component
#368
docs: translation for option
component
#368
Conversation
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
option
componentoption
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tinggal nunggu soal caveat
aja nih yang masih rancu, overall okay dariku
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Halo mas @aroyan, please take a look at these requested changes:
Co-authored-by: Resi Respati <[email protected]>
Sure, it's updated now |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Asking peer review @r17x @mhaidarhanif @zainfathoni. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change.
Co-authored-by: M Haidar Hanif <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aroyan Outside of @mhaidarhanif's suggestion, all good. Please make the necessary changes.
Co-authored-by: Resi Respati <[email protected]>
@mhaidarhanif @resir014 updated to original values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. @mhaidarhanif please review again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final tiny details to improve
Co-authored-by: M Haidar Hanif <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, approved 👍
Co-authored-by: Resi Respati <[email protected]> Co-authored-by: M Haidar Hanif <[email protected]> Co-authored-by: Irfan Maulana <[email protected]> Co-authored-by: Zain Fathoni <[email protected]>
Related to #330
Closes #424