fix: support linking of BaseReactPackage subclasses #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Dec 12, 2024
packages/cli-config-android/src/config/__tests__/findPackageClassName.test.ts
Outdated
Show resolved
Hide resolved
thymikee
approved these changes
Dec 12, 2024
|
Thanks! I can port that to older versions once merged |
…assName.test.ts Co-authored-by: Michał Pierzchała <[email protected]>
thymikee
added a commit
that referenced
this pull request
Dec 12, 2024
* fix: support linking of BaseReactPackage subclasses * Update packages/cli-config-android/src/config/__tests__/findPackageClassName.test.ts Co-authored-by: Michał Pierzchała <[email protected]> --------- Co-authored-by: Michał Pierzchała <[email protected]>
thymikee
added a commit
that referenced
this pull request
Dec 12, 2024
* fix: support linking of BaseReactPackage subclasses * Update packages/cli-config-android/src/config/__tests__/findPackageClassName.test.ts Co-authored-by: Michał Pierzchała <[email protected]> --------- Co-authored-by: Michał Pierzchała <[email protected]>
|
This is now released in:
|
|
Great stuff folks! |
vonovak
referenced
this pull request
in facebook/react-native
Dec 16, 2024
Summary: Pull Request resolved: #47680 This was deprecated in D50128456 so should be safe to remove now. Changelog: [Android][Removed] Removed TurboReactPackage, which was replaced by BaseReactPackage Reviewed By: mdvacca Differential Revision: D66127067 fbshipit-source-id: a4090ab439cf99dc693622b8da2c0cffa247ad24
This was referenced Dec 17, 2024
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
TurboReactPackageis deprecated and the advice is to useBaseReactPackage. However, the cli does not recognizeBaseReactPackageas something that should be autolinked, so following the advice actually breaks apps with:Would be nice to have this picked to older cli versions too.
Test Plan:
You can see test failures in react-native-datetimepicker/datetimepicker#950 prior to applying the patch and after patching, tests are green.
Checklist