Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use BaseReactPackage instead of TurboReactPackage #2546

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mrousavy
Copy link

@mrousavy mrousavy commented Dec 3, 2024

Description

This is required for RN 0.77 apparently. TurboReactPackage is deprecated on new arch. No idea why.

I am not sure about backwards compatibility either, sorry.

Feel free to close this PR if this isn't backwards compatible.

Changes

Test code and steps to reproduce

Checklist

This is required for RN 0.77 apparently. TurboReactPackage is deprecated on new arch. No idea why.
@vonovak
Copy link

vonovak commented Dec 5, 2024

FYI TurboReactPackage was added back in 77 rc 1

@mrousavy
Copy link
Author

mrousavy commented Dec 6, 2024

yep saw that. But it's still deprecated for some reason

@kkafar
Copy link
Member

kkafar commented Dec 6, 2024

Thanks, I don' have PR for 0.77 support yet, will be working on it somewhere next week most likely. I'll cherry pick your commit to the bigger PR then

@kkafar
Copy link
Member

kkafar commented Dec 18, 2024

I'm adding 0.77 support in #2581 - I'll merge this PR there

@kkafar kkafar changed the base branch from main to @kkafar/support-0.77 December 18, 2024 14:53
@kkafar kkafar merged commit a8cd2b5 into software-mansion:@kkafar/support-0.77 Dec 18, 2024
4 checks passed
@kkafar
Copy link
Member

kkafar commented Dec 18, 2024

Thanks!

@vonovak
Copy link

vonovak commented Dec 18, 2024

hi @kkafar imho it's best to hold off this change because only the very latest versions of RNC cli support this: react-native-community/cli#2563

OR you can do this kind of thing: https://github.com/th3rdwave/react-native-safe-area-context/blob/29d12106ea19180b6c898812796b14c703090b61/android/src/main/java/com/th3rdwave/safeareacontext/SafeAreaContextPackage.kt#L11

TY :)

@kkafar
Copy link
Member

kkafar commented Dec 20, 2024

Thanks for the heads up @vonovak!

@kkafar
Copy link
Member

kkafar commented Dec 20, 2024

I'll go with the "comment trick"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants