-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interview): apply to all [2] #1125
Draft
jochenklar
wants to merge
6
commits into
interview-visibility
Choose a base branch
from
interview-apply-to-all
base: interview-visibility
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f017685
Fix set creation
jochenklar 365ad23
Fix valueIndex computation, again
jochenklar c94680c
Fix CheckboxInput component
jochenklar 0fe1b55
Fix interviewReducer
jochenklar 54f887a
Add copyValue action to interview
jochenklar 498ae19
Check siblings for copyValues and use copyValues for all is_collectio…
jochenklar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
rdmo/projects/assets/js/interview/components/main/question/QuestionCopyValue.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import React from 'react' | ||
import PropTypes from 'prop-types' | ||
|
||
import { isEmptyValue } from '../../../utils/value' | ||
|
||
const QuestionCopyValue = ({ question, value, siblings, copyValue }) => { | ||
return ( | ||
question.set_collection && | ||
!question.is_collection && | ||
!isEmptyValue(value) && | ||
siblings.some((value) => isEmptyValue(value)) && ( | ||
<button className="btn btn-link btn-apply-to-all" onClick={() => copyValue(value, siblings)} | ||
title={gettext('Apply this answer to all tabs where this question is empty')}> | ||
<i className="fa fa-arrow-circle-right fa-btn"></i> | ||
</button> | ||
) | ||
) | ||
} | ||
|
||
QuestionCopyValue.propTypes = { | ||
question: PropTypes.object.isRequired, | ||
value: PropTypes.object.isRequired, | ||
siblings: PropTypes.object.isRequired, | ||
copyValue: PropTypes.func.isRequired | ||
} | ||
|
||
export default QuestionCopyValue |
38 changes: 38 additions & 0 deletions
38
rdmo/projects/assets/js/interview/components/main/question/QuestionCopyValues.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import React from 'react' | ||
import PropTypes from 'prop-types' | ||
|
||
import { isEmptyValue } from '../../../utils/value' | ||
|
||
const QuestionCopyValues = ({ question, values, siblings, copyValue }) => { | ||
const handleCopyValues = () => { | ||
values.forEach((value) => copyValue(value)) | ||
} | ||
|
||
const button = question.widget_type == 'checkbox' ? ( | ||
<button className="btn btn-link btn-apply-to-all" onClick={handleCopyValues} | ||
title={gettext('Apply this answer to all tabs where this question is empty')}> | ||
<i className="fa fa-arrow-circle-right fa-btn"></i> | ||
</button> | ||
) : ( | ||
<button type="button" className="btn btn-primary btn-xs copy-value-button ml-10" onClick={handleCopyValues}> | ||
<i className="fa fa-arrow-circle-right fa-btn"></i> {gettext('Apply to all')} | ||
</button> | ||
) | ||
|
||
return ( | ||
question.is_collection && | ||
question.set_collection && | ||
values.some((v) => !isEmptyValue(v)) && | ||
siblings.some((value) => isEmptyValue(value)) && | ||
button | ||
) | ||
} | ||
|
||
QuestionCopyValues.propTypes = { | ||
question: PropTypes.object.isRequired, | ||
values: PropTypes.array.isRequired, | ||
siblings: PropTypes.array, | ||
copyValue: PropTypes.func.isRequired | ||
} | ||
|
||
export default QuestionCopyValues |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this not be
siblings: PropTypes.array.isRequired,
, anarray
insteadobject
? The browser showed an error about it..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes , will fix!