Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interview): apply to all [2] #1125

Draft
wants to merge 6 commits into
base: interview-visibility
Choose a base branch
from

Conversation

jochenklar
Copy link
Member

This PR adds a copyValue action to the new interface, which can be used to copy values to different tabs of a page.

@jochenklar jochenklar self-assigned this Aug 16, 2024
@jochenklar jochenklar added this to the RDMO 2.3.0 milestone Aug 16, 2024
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is front-end only, so it does not require any tests 😶‍🌫️

Ive tried out answering some questions and applying the answers to other datasets, it functions intuitively.

One problem I found for the multiple text answer types, where I could not see the button "apply to all" anymore after filling-out and removing again. Are these values not properly compared? And should I also be able to apply-to-all after i just add another entry or not?

apply-to-all-and-2-multiple-text-widgets

Another thing is about the radio buttons, they are floating over, but it's not for this PR I guess, see picture.

apply-to-all-and-1

QuestionCopyValue.propTypes = {
question: PropTypes.object.isRequired,
value: PropTypes.object.isRequired,
siblings: PropTypes.object.isRequired,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be siblings: PropTypes.array.isRequired, , an array instead object? The browser showed an error about it..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes , will fix!

@jochenklar
Copy link
Member Author

The radio button problem should be fixed in 24f6831.

@jochenklar
Copy link
Member Author

About the apply to all, it works like expected (by me 😄 ). It apears only if the question in at least one of the "sibling" sets has no or only empty values. Maybe we discuss how the feature should work when showing it to more users.

@jochenklar jochenklar changed the title Interview apply to all feature(interview): apply to all [2] Nov 19, 2024
@jochenklar jochenklar changed the title feature(interview): apply to all [2] feat(interview): apply to all [2] Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants