-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interview): apply to all [2] #1125
base: interview-visibility
Are you sure you want to change the base?
Conversation
199863c
to
be2dea7
Compare
5c65410
to
498ae19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is front-end only, so it does not require any tests 😶🌫️
Ive tried out answering some questions and applying the answers to other datasets, it functions intuitively.
One problem I found for the multiple text answer types, where I could not see the button "apply to all" anymore after filling-out and removing again. Are these values not properly compared? And should I also be able to apply-to-all after i just add another entry or not?
Another thing is about the radio buttons, they are floating over, but it's not for this PR I guess, see picture.
QuestionCopyValue.propTypes = { | ||
question: PropTypes.object.isRequired, | ||
value: PropTypes.object.isRequired, | ||
siblings: PropTypes.object.isRequired, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this not be siblings: PropTypes.array.isRequired,
, an array
instead object
? The browser showed an error about it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes , will fix!
The radio button problem should be fixed in 24f6831. |
About the apply to all, it works like expected (by me 😄 ). It apears only if the question in at least one of the "sibling" sets has no or only empty values. Maybe we discuss how the feature should work when showing it to more users. |
This PR adds a copyValue action to the new interface, which can be used to copy values to different tabs of a page.