Add actors sorted by CRC in Bmsld entity groups #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 73.45% 73.70% +0.25%
==========================================
Files 58 58
Lines 3066 3073 +7
==========================================
+ Hits 2252 2265 +13
+ Misses 814 808 -6
☔ View full report in Codecov by Sentry. |
duncathan
previously requested changes
Oct 18, 2023
dyceron
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope that we finally figured it out: The "magic" sorting of the actors is by their crc32 value, so MEDS should take care of that and provide the helper functions.
(btw: I'm open for a more efficient way to keep the list sorted)