Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing checkpoints for most multi-entrance Metroids #161

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

dyceron
Copy link
Collaborator

@dyceron dyceron commented Oct 18, 2023

Did not test most of these since it requires randovania/mercury-engine-data-structures#88 to be merged first, otherwise rooms break

  • Added checkpoints to all but two multi-room Metroids (skipped ones connect to an item room so checkpoint isn't that important)
  • Renamed Gamma 2b checkpoints to match the vanilla naming scheme

@dyceron dyceron requested a review from ThanatosGit October 18, 2023 03:02
@dyceron dyceron marked this pull request as draft October 18, 2023 03:10
Copy link
Collaborator

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like most, but not all, methods follow the same pattern. Could maybe generalize it later.

@dyceron dyceron marked this pull request as ready for review October 20, 2023 22:46
@dyceron dyceron merged commit 51798c9 into main Oct 20, 2023
6 checks passed
@ThanatosGit ThanatosGit deleted the metroids branch November 6, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants