Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade outdated golang dependencies #326

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

harsimranmaan
Copy link
Contributor

@harsimranmaan harsimranmaan commented Aug 8, 2024

Some Golang CVEs get flagged in the suc binary as it was built with an older golang version. Use go 1.22.6
Updating other go module deps.
SLES update is required for libc compatiblity with latest ginkgo version.

Update golangci-lint. Most gingko and gomega changes are to fix linting failures.
Update sonobuoy

docker bridge address is added to tls-san to avoid cert errors when using the client to connect the KUBEHOST.

Drop deprecated version field in the docker compose manifests.

It is recommended that the next release be v0.15.0 as 0.14.0 was already published and deleted in the past and gosumdb already has entries.

Tested manually with a drop in replacement for the older suc binary for k3s upgrade from v1.28.7 to 1.29.6.

Passing test suite: harsimranmaan#1

Relates #314

Some Golang CVEs get flagged in the suc binary as it was built with an
older golang version. Use go 1.22.6
Updating other go module deps.
SLES update is required for libc compatiblity with latest ginkgo
version.

Update golangci-lint. Most gingko and gomega changes are to fix linting
failures.
Update sonobuoy

docker bridge address is added to tls-san to avoid cert errors when
using the client to connect the KUBEHOST.

Drop deprecated version field in the docker compose manifests.

It is recommended that the next release be v0.15.0 as 0.14.0 was already
published and deleted in the past and gosumdb already has entries.
@harsimranmaan harsimranmaan changed the title Upgrade dependencies Upgrade outdated golang dependencies Aug 9, 2024
@harsimranmaan
Copy link
Contributor Author

Hi @brandond , can you share other packaging changes that you'll like here?

Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! one nit on the test framework changes.

e2e/suite/channel_resolve_test.go Outdated Show resolved Hide resolved
@harsimranmaan
Copy link
Contributor Author

harsimranmaan commented Aug 20, 2024

Will do. I'll add a golancilint exception as it was complaining

@harsimranmaan harsimranmaan requested a review from brandond August 20, 2024 18:36
@brandond brandond merged commit de72632 into rancher:master Aug 27, 2024
2 checks passed
lumiere-bot bot referenced this pull request in coolguy1771/home-ops Sep 26, 2024
…0.14.0 ) (minor) (#5496)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| docker.io/rancher/system-upgrade-controller | minor | `v0.13.4` ->
`v0.14.0` |
|
[rancher/system-upgrade-controller](https://redirect.github.com/rancher/system-upgrade-controller)
| minor | `v0.13.4` -> `v0.14.0` |

---

### Release Notes

<details>
<summary>rancher/system-upgrade-controller
(rancher/system-upgrade-controller)</summary>

###
[`v0.14.0`](https://redirect.github.com/rancher/system-upgrade-controller/releases/tag/v0.14.0)

[Compare
Source](https://redirect.github.com/rancher/system-upgrade-controller/compare/v0.13.4...v0.14.0)

##### What's Changed

- fix: Drop unneeded reorder surpression by
[@&#8203;SISheogorath](https://redirect.github.com/SISheogorath) in
[https://github.com/rancher/system-upgrade-controller/pull/296](https://redirect.github.com/rancher/system-upgrade-controller/pull/296)
- Update/fix README kustomize command by
[@&#8203;SISheogorath](https://redirect.github.com/SISheogorath) in
[https://github.com/rancher/system-upgrade-controller/pull/297](https://redirect.github.com/rancher/system-upgrade-controller/pull/297)
- Add GHA workflows by
[@&#8203;bfbachmann](https://redirect.github.com/bfbachmann) in
[https://github.com/rancher/system-upgrade-controller/pull/311](https://redirect.github.com/rancher/system-upgrade-controller/pull/311)
- Upgrade outdated golang dependencies by
[@&#8203;harsimranmaan](https://redirect.github.com/harsimranmaan) in
[https://github.com/rancher/system-upgrade-controller/pull/326](https://redirect.github.com/rancher/system-upgrade-controller/pull/326)
- feat: allow pod replacement policy override by
[@&#8203;buroa](https://redirect.github.com/buroa) in
[https://github.com/rancher/system-upgrade-controller/pull/328](https://redirect.github.com/rancher/system-upgrade-controller/pull/328)
- fix: system-upgrade-controller-drainer: add missing delete permission
for pods in clusterrole by
[@&#8203;damdo](https://redirect.github.com/damdo) in
[https://github.com/rancher/system-upgrade-controller/pull/320](https://redirect.github.com/rancher/system-upgrade-controller/pull/320)
- Bump golang.org/x/net from 0.17.0 to 0.23.0 in /pkg/apis by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/rancher/system-upgrade-controller/pull/307](https://redirect.github.com/rancher/system-upgrade-controller/pull/307)
- Fix GHA release workflow by
[@&#8203;brandond](https://redirect.github.com/brandond) in
[https://github.com/rancher/system-upgrade-controller/pull/330](https://redirect.github.com/rancher/system-upgrade-controller/pull/330)
- Fix image tag by
[@&#8203;brandond](https://redirect.github.com/brandond) in
[https://github.com/rancher/system-upgrade-controller/pull/331](https://redirect.github.com/rancher/system-upgrade-controller/pull/331)
- Fix artifact permissions by
[@&#8203;brandond](https://redirect.github.com/brandond) in
[https://github.com/rancher/system-upgrade-controller/pull/332](https://redirect.github.com/rancher/system-upgrade-controller/pull/332)

##### New Contributors

- [@&#8203;bfbachmann](https://redirect.github.com/bfbachmann) made
their first contribution in
[https://github.com/rancher/system-upgrade-controller/pull/311](https://redirect.github.com/rancher/system-upgrade-controller/pull/311)
- [@&#8203;harsimranmaan](https://redirect.github.com/harsimranmaan)
made their first contribution in
[https://github.com/rancher/system-upgrade-controller/pull/326](https://redirect.github.com/rancher/system-upgrade-controller/pull/326)
- [@&#8203;damdo](https://redirect.github.com/damdo) made their first
contribution in
[https://github.com/rancher/system-upgrade-controller/pull/320](https://redirect.github.com/rancher/system-upgrade-controller/pull/320)

**Full Changelog**:
rancher/system-upgrade-controller@v0.13.4...v0.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45NS40IiwidXBkYXRlZEluVmVyIjoiMzguOTUuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL21pbm9yIl19-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants