Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing package windows step in release #6387

Merged
merged 2 commits into from
Jul 22, 2024
+4 −0
Merged

Add missing package windows step in release #6387

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bf3118
Add missing package windows step in release
galal-hussein Jul 22, 2024
4f76b1f
fix typo
galal-hussein Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ jobs:
DOCKER_USERNAME: ${{ env.DOCKER_USERNAME }}
DOCKER_PASSWORD: ${{ env.DOCKER_PASSWORD }}

- name: Pacakge windows images
Copy link
Member

@brandond brandond Jul 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling nit

Suggested change
- name: Pacakge windows images
- name: Package windows images

Also, shouldn't this go above, either directly below the existing Package Images step, or perhaps just as another run line in that same step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix the typo, however the order is actually what it used to be in drone
https://github.com/rancher/rke2/blob/v1.28.11-rc6%2Brke2r1/.drone.yml#L160C1-L172C1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

We need to review the makefile when we get rid of dapper, I think we are rebuilding the same stuff many times.

run: |
GITHUB_ACTION_TAG=${{ github.ref_name }} dapper -f Dockerfile --target dapper make package-windows-images

- name: Checksum Artifacts
run: |
GITHUB_ACTION_TAG=${{ github.ref_name }} dapper -f Dockerfile --target dapper make checksum
Expand Down
Loading