Add missing package windows step in release #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: galal-hussein <[email protected]>
rafaelbreno
approved these changes
Jul 22, 2024
briandowns
approved these changes
Jul 22, 2024
brandond
requested changes
Jul 22, 2024
.github/workflows/release.yml
Outdated
| @@ -63,6 +63,10 @@ jobs: | |||
| DOCKER_USERNAME: ${{ env.DOCKER_USERNAME }} | |||
| DOCKER_PASSWORD: ${{ env.DOCKER_PASSWORD }} | |||
|
|
|||
| - name: Pacakge windows images | |||
There was a problem hiding this comment.
Spelling nit
Suggested change
| - name: Pacakge windows images | |
| - name: Package windows images |
Also, shouldn't this go above, either directly below the existing Package Images step, or perhaps just as another run line in that same step?
There was a problem hiding this comment.
I will fix the typo, however the order is actually what it used to be in drone
https://github.com/rancher/rke2/blob/v1.28.11-rc6%2Brke2r1/.drone.yml#L160C1-L172C1
There was a problem hiding this comment.
ok!
We need to review the makefile when we get rid of dapper, I think we are rebuilding the same stuff many times.
Signed-off-by: galal-hussein <[email protected]>
brandond
approved these changes
Jul 22, 2024
iamsarthakk
pushed a commit
to iamsarthakk/rke2
that referenced
this pull request
Aug 19, 2024
* Add missing package windows step in release Signed-off-by: galal-hussein <[email protected]> * fix typo Signed-off-by: galal-hussein <[email protected]> --------- Signed-off-by: galal-hussein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments