[2.10 backport] Avoid embedding web-worker polyfill #12561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
approved these changes
Nov 14, 2024
|
@moio this one will need a rebase as well. the mirror used to install chrome recently started failing and should have been fixed in release-2.10 |
The BLOB code from web-worker is minified, and contains source maps that are then passed over by webpack - that creates a situation of minified code inside BLOB inside minified code which confuses some tools, eg. jantimon/chrome-profile-sourcemap-resolver#4 That could be fixed, but the only reason to do so would be supporting very old (pre-2013) browsers, so we are better off removing the polyfill altogether. Signed-off-by: Silvio Moioli <[email protected]>
moio
force-pushed
the
no_webworker_polyfill_210
branch
from
1e3ee49
to
8110cb2
Compare
|
@richard-cox for some reason it is still failing after rebase, is there anything else I should do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fxes: #12514
Port of #12400
Checklist