Skip to content

Commit

Permalink
Avoid embedding web-worker polyfill
Browse files Browse the repository at this point in the history
The BLOB code from web-worker is minified, and contains source maps that are then
passed over by webpack - that creates a situation of minified code inside BLOB
inside minified code which confuses some tools, eg.

jantimon/chrome-profile-sourcemap-resolver#4

That could be fixed, but the only reason to do so would be supporting very old
(pre-2013) browsers, so we are better off removing the polyfill altogether.

Signed-off-by: Silvio Moioli <[email protected]>
  • Loading branch information
moio committed Nov 25, 2024
1 parent 674e698 commit 8110cb2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions shell/vue.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,11 @@ const instrumentCode = () => {
};

const getLoaders = (SHELL_ABS) => [
// Ensure there is a fallback for browsers that don't support web workers
// no fallback for pre-2013 browsers https://caniuse.com/webworkers
{
test: /web-worker.[a-z-]+.js/i,
loader: 'worker-loader',
options: { inline: 'fallback' },
options: { inline: 'no-fallback' },
},
// Handler for csv files (e.g. ec2 instance data)
{
Expand Down

0 comments on commit 8110cb2

Please sign in to comment.