-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discontinued faces #5
Draft
Amndeep7
wants to merge
9
commits into
r-anime:master
Choose a base branch
from
Amndeep7:add_discontinued_faces
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Jan 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 028bad3 - Browse repository at this point
Copy the full SHA 028bad3View commit details
Commits on Jan 17, 2022
-
Actual introduction date of gununu was on 2011-07-26.
As far as I can tell, there is nothing significant about 2012-12-16. The original release of commentfaces (using the `/` syntax) came on 2011-07-26: https://old.reddit.com/r/anime/comments/izxos/comment_faces_for_ranime/ The commentface refresh to use the new syntax and introduction to several more faces occurred on 2015-02-13, but gununu and 17 others predate that and consequently the introduction date should reflect that accordingly.
Configuration menu - View commit details
-
Copy full SHA for 30b3dcf - Browse repository at this point
Copy the full SHA 30b3dcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 342af28 - Browse repository at this point
Copy the full SHA 342af28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61b4f10 - Browse repository at this point
Copy the full SHA 61b4f10View commit details -
The actual date for the early 2016 comment face removal is uncertain, so I decided to move forward with 2011-03-21 for the following reasons: 1) The comment faces page (https://old.reddit.com/r/anime/wiki/commentfaces) says early 2016. 2) The retired comment faces page which contains the data for the screencap for the comment faces page was last updated on 2016-03-14. 3) Archives from the wayback machine on and immediately after that date still contain the old comment faces. The earliest archive I can get to resolve from there with those faces removed is 2016-03-29. The last archive I can get to resolve from there still containing those faces is 2016-03-18. 4) The removed date is after the date that the new faces were announced and presumably provided (2016-03-21 - https://old.reddit.com/r/anime/comments/4babw1/new_comment_faces/). 5) I'm presuming that the announcement date for the new faces aligns with the removal date for the old ones in order to have space for the new ones in the first place and also to provide the smoothest transition between them.
Configuration menu - View commit details
-
Copy full SHA for b661eb6 - Browse repository at this point
Copy the full SHA b661eb6View commit details
Commits on Jan 18, 2022
-
I'm agreeing with the discontinue date of 5 April 2017 since the removals wiki page's last edit for the series of edits related to that purge was on 4 April 2017 so it's feasible enough to me that the actual turnover date was the next day.
Configuration menu - View commit details
-
Copy full SHA for d3b9e93 - Browse repository at this point
Copy the full SHA d3b9e93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59f81bc - Browse repository at this point
Copy the full SHA 59f81bcView commit details -
Renamed files and folders to be a hash of ${name}_${released_on} instead
of just ${name} because names are not necessarily unique across commentfaces (see pointandlaugh or the masked faces). Ran `awk -F, '{ print $1, $16 }' ../../comment_face_list.csv | while read name date; do if [ -d "$name" ]; then rename "s/.*/${name}_${date}/" $name; fi; done` to rename directories that were in the PWD and `awk -F, '{ print $1, $16 }' ../../comment_face_list.csv | while read name date; do if [ -f "$name".* ]; then rename "s/(.*)\.(.*)/${name}_${date}.\$2/" $name.*; fi; done` to rename files that were in the PWD.
Configuration menu - View commit details
-
Copy full SHA for 37acade - Browse repository at this point
Copy the full SHA 37acadeView commit details -
had to manually merge from master since the file name changes were ma…
…king things not behave right
Configuration menu - View commit details
-
Copy full SHA for 35b2acc - Browse repository at this point
Copy the full SHA 35b2accView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.