Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discontinued faces #5

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on Jan 11, 2022

  1. Configuration menu
    Copy the full SHA
    028bad3 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Actual introduction date of gununu was on 2011-07-26.

    As far as I can tell, there is nothing significant about 2012-12-16.
    The original release of commentfaces (using the `/` syntax) came on
    2011-07-26:
    https://old.reddit.com/r/anime/comments/izxos/comment_faces_for_ranime/
    
    The commentface refresh to use the new syntax and introduction to
    several more faces occurred on 2015-02-13, but gununu and 17 others
    predate that and consequently the introduction date should reflect that
    accordingly.
    Amndeep7 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    30b3dcf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    342af28 View commit details
    Browse the repository at this point in the history
  3. yunocaine

    Amndeep7 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    61b4f10 View commit details
    Browse the repository at this point in the history
  4. somad

    The actual date for the early 2016 comment face removal is uncertain, so
    I decided to move forward with 2011-03-21 for the following reasons:
    
    1) The comment faces page
    (https://old.reddit.com/r/anime/wiki/commentfaces) says early 2016.
    2) The retired comment faces page which contains the data for the
    screencap for the comment faces page was last updated on 2016-03-14.
    3) Archives from the wayback machine on and immediately after that date
    still contain the old comment faces.  The earliest archive I can get to
    resolve from there with those faces removed is 2016-03-29.  The last
    archive I can get to resolve from there still containing those faces is
    2016-03-18.
    4) The removed date is after the date that the new faces were announced
    and presumably provided (2016-03-21 -
    https://old.reddit.com/r/anime/comments/4babw1/new_comment_faces/).
    5) I'm presuming that the announcement date for the new faces aligns
    with the removal date for the old ones in order to have space for the
    new ones in the first place and also to provide the smoothest transition
    between them.
    Amndeep7 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    b661eb6 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. shocked

    I'm agreeing with the discontinue date of 5 April 2017 since the
    removals wiki page's last edit for the series of edits related to that
    purge was on 4 April 2017 so it's feasible enough to me that the actual
    turnover date was the next day.
    Amndeep7 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    d3b9e93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    59f81bc View commit details
    Browse the repository at this point in the history
  3. Renamed files and folders to be a hash of ${name}_${released_on} instead

    of just ${name} because names are not necessarily unique across
    commentfaces (see pointandlaugh or the masked faces).
    
    Ran `awk -F, '{ print $1, $16 }' ../../comment_face_list.csv | while
    read name date; do if [ -d "$name" ]; then rename
    "s/.*/${name}_${date}/" $name; fi; done` to rename directories that were
    in the PWD and `awk -F, '{ print $1, $16 }' ../../comment_face_list.csv
    | while read name date; do if [ -f "$name".* ]; then rename
    "s/(.*)\.(.*)/${name}_${date}.\$2/" $name.*; fi; done` to rename files
    that were in the PWD.
    Amndeep7 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    37acade View commit details
    Browse the repository at this point in the history
  4. had to manually merge from master since the file name changes were ma…

    …king things not behave right
    Amndeep7 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    35b2acc View commit details
    Browse the repository at this point in the history