Add discontinued faces #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to ping me on reddit/discord once this is ready for review if I don't notice, my Github notifications have been a mess lately |
|
Sounds good @eritbh |
As far as I can tell, there is nothing significant about 2012-12-16. The original release of commentfaces (using the `/` syntax) came on 2011-07-26: https://old.reddit.com/r/anime/comments/izxos/comment_faces_for_ranime/ The commentface refresh to use the new syntax and introduction to several more faces occurred on 2015-02-13, but gununu and 17 others predate that and consequently the introduction date should reflect that accordingly.
The actual date for the early 2016 comment face removal is uncertain, so I decided to move forward with 2011-03-21 for the following reasons: 1) The comment faces page (https://old.reddit.com/r/anime/wiki/commentfaces) says early 2016. 2) The retired comment faces page which contains the data for the screencap for the comment faces page was last updated on 2016-03-14. 3) Archives from the wayback machine on and immediately after that date still contain the old comment faces. The earliest archive I can get to resolve from there with those faces removed is 2016-03-29. The last archive I can get to resolve from there still containing those faces is 2016-03-18. 4) The removed date is after the date that the new faces were announced and presumably provided (2016-03-21 - https://old.reddit.com/r/anime/comments/4babw1/new_comment_faces/). 5) I'm presuming that the announcement date for the new faces aligns with the removal date for the old ones in order to have space for the new ones in the first place and also to provide the smoothest transition between them.
of just ${name} because names are not necessarily unique across
commentfaces (see pointandlaugh or the masked faces).
Ran `awk -F, '{ print $1, $16 }' ../../comment_face_list.csv | while
read name date; do if [ -d "$name" ]; then rename
"s/.*/${name}_${date}/" $name; fi; done` to rename directories that were
in the PWD and `awk -F, '{ print $1, $16 }' ../../comment_face_list.csv
| while read name date; do if [ -f "$name".* ]; then rename
"s/(.*)\.(.*)/${name}_${date}.\$2/" $name.*; fi; done` to rename files
that were in the PWD.
…king things not behave right
|
lmao github is not happy with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Amndeep7/commentface_counting#4