This repository has been archived by the owner on Oct 1, 2020. It is now read-only.
fixing pep8 from master branch #680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonokubo
reviewed
Jun 18, 2019
| @@ -230,13 +230,13 @@ def metadata(self): | |||
| # TODO: get metadata from database | |||
| # TODO: implement libratar/gravatar | |||
| # return { | |||
| # 'cover': 'foo', | |||
quokka/core/content/utils.py
Outdated
| @@ -10,9 +10,10 @@ def url_for_content(content, include_ext=True): | |||
| else: | |||
| data = content | |||
|
|
|||
| category_slug_data = data.get('category_slug') | |||
| category_data = slugify_category(data.get('category') or '') | |||
There was a problem hiding this comment.
See: data.get('category', '') maybe it's simpler
There was a problem hiding this comment.
done;
commit => marcosptf@9ab0245
This was referenced Jul 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
every pr that i've worked, had problems with it, the idea this branch is just fix it from branch master;
pr enable to merge;
Att,
@marcosptf