-
Notifications
You must be signed in to change notification settings - Fork 447
fixing XSS vulnerability #678
base: master
Are you sure you want to change the base?
Conversation
Hello @marcosptf! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-06-07 10:54:37 UTC |
error fixed and pytest to xss prevent created |
# 'og_image': 'foo', | ||
# 'series': 'aa', | ||
# 'asides': 'aaa' | ||
# 'cover': 'foo', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider remover these comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already fixed in another pr => #680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Just look the comments.
im working to fix the issue #675 ;
pr enable to merge:
->quokka/utils/text.py
was create a new function to validate and remove any tags from string;
remove_tags_from_string();
->tests/utils/test_text.py
was added test to neew function created:
test_remove_tags_from_string();
Att,
@marcosptf