Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Add makeTimeDataFrame and makeMixedDataFrame to pueblo.testing.pandas #59

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 23, 2024

About

pandas._testing.{makeTimeDataFrame,makeMixedDataFrame} were removed on behalf of pandas 2.2.0. This patch vendorizes them, to provide polyfills to downstream projects which need them.

Synopsis

from pueblo.testing.pandas import makeMixedDataFrame, makeTimeDataFrame

df = makeTimeDataFrame(nper=42, freq="S")
df = makeMixedDataFrame()

References

Upstream

Downstream

The routines are used within test harnesses of those downstream projects, where corresponding updates to pandas 2.2.0 are tripping CI.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eeaa08d) 75.17% compared to head (c9213ad) 89.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #59       +/-   ##
===========================================
+ Coverage   75.17%   89.72%   +14.55%     
===========================================
  Files          21       22        +1     
  Lines         729      740       +11     
===========================================
+ Hits          548      664      +116     
+ Misses        181       76      -105     
Flag Coverage Δ
main 75.54% <100.00%> (+0.36%) ⬆️
ngr 62.70% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl changed the title Testing: Add pueblo.testing.pandas.makeTimeDataFrame Testing: Add makeTimeDataFrame and makeMixedDataFrame to pueblo.testing.pandas Jan 24, 2024
@amotl amotl self-assigned this Jan 24, 2024
It was removed from `pandas._testing` on behalf of pandas 2.2.0.
@amotl amotl force-pushed the pandas-testing branch 2 times, most recently from 258a610 to c9213ad Compare January 29, 2024 19:27
amotl added 5 commits January 29, 2024 20:31
It was removed from `pandas._testing` on behalf of pandas 2.2.0.
Pyarrow will become a required dependency of pandas in the next major release of pandas
(pandas 3.0), (to allow more performant data types, such as the Arrow string type, and
better interoperability with other libraries) but was not found to be installed on your
system.
@amotl amotl marked this pull request as ready for review January 29, 2024 19:34
@amotl amotl merged commit 8176bd8 into main Jan 29, 2024
@amotl amotl deleted the pandas-testing branch January 29, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant