-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing: Add makeTimeDataFrame
and makeMixedDataFrame
to pueblo.testing.pandas
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
===========================================
+ Coverage 75.17% 89.72% +14.55%
===========================================
Files 21 22 +1
Lines 729 740 +11
===========================================
+ Hits 548 664 +116
+ Misses 181 76 -105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amotl
changed the title
Testing: Add
Testing: Add Jan 24, 2024
pueblo.testing.pandas.makeTimeDataFrame
makeTimeDataFrame
and makeMixedDataFrame
to pueblo.testing.pandas
This was referenced Jan 24, 2024
It was removed from `pandas._testing` on behalf of pandas 2.2.0.
amotl
force-pushed
the
pandas-testing
branch
2 times, most recently
from
January 29, 2024 19:27
258a610
to
c9213ad
Compare
It was removed from `pandas._testing` on behalf of pandas 2.2.0.
Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0), (to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries) but was not found to be installed on your system.
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
pandas._testing.{makeTimeDataFrame,makeMixedDataFrame}
were removed on behalf of pandas 2.2.0. This patch vendorizes them, to provide polyfills to downstream projects which need them.Synopsis
References
Upstream
Downstream
The routines are used within test harnesses of those downstream projects, where corresponding updates to pandas 2.2.0 are tripping CI.
pandas._testing.makeTimeDataFrame
crate/cratedb-examples#240