Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST/CLN: Remove makeTime methods #56264

Merged
merged 6 commits into from
Dec 1, 2023
Merged

TST/CLN: Remove makeTime methods #56264

merged 6 commits into from
Dec 1, 2023

Conversation

mroeschke
Copy link
Member

No description provided.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Clean labels Nov 30, 2023
@mroeschke mroeschke added this to the 2.2 milestone Nov 30, 2023
WillAyd
WillAyd approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pandas/tests/io/pytables/test_select.py
@@ -388,7 +408,7 @@ def test_select_iterator(tmp_path, setup_path):
# full selection
expected = store.select_as_multiple(["df1", "df2"], selector="df1")
results = list(
store.select_as_multiple(["df1", "df2"], selector="df1", chunksize=150)
store.select_as_multiple(["df1", "df2"], selector="df1", chunksize=2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for performance?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, exactly

@mroeschke mroeschke merged commit 147d68a into pandas-dev:main Dec 1, 2023
44 checks passed
@mroeschke mroeschke deleted the tst/makeTime branch December 1, 2023 18:37
@amotl amotl mentioned this pull request Jan 24, 2024
Merged
@amotl
Copy link

amotl commented Jan 30, 2024 •
edited
Loading

Hi. To all people finding this: In a similar spirit like verlib2, we rescued the corresponding testing helper methods makeTimeDataFrame and makeMixedDataFrame, and made them available on behalf of the pueblo package, for all downstream packages which absolutely need them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @amotl @WillAyd