Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngr: Fix Gradle test runner by removing invocation of install target #26

Merged
merged 1 commit into from
Nov 23, 2023
Merged

ngr: Fix Gradle test runner by removing invocation of install target #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
- Add a few testing helper utilities to `pueblo.testing`
- Fix dependencies for `test` extra by downgrading to `nbdime<4`
- Dependencies (extras): Remove "ngr", add "notebook", link "test" to "testing"
- ngr: Gradle test runner failed to invoke `./gradlew install` because such a
target did not exist.

## 2023-11-06 v0.0.3
- ngr: Fix `contextlib.chdir` only available on Python 3.11 and newer
Expand Down
1 change: 0 additions & 1 deletion pueblo/ngr/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ def install(self) -> None:
elif self.has_gradle_files:
if shutil.which("gradle"):
run_command("gradle wrapper")
run_command("./gradlew install")
else:
raise NotImplementedError("Unable to invoke target: install")
matriv marked this conversation as resolved.
Show resolved Hide resolved

Expand Down