Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngr: Fix Gradle test runner by removing invocation of install target #26

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 22, 2023

Problem

The Gradle test runner failed to invoke ./gradlew install, because such a target did not exist.

References

Solution

Remove invoking the install target and see if we can get along without.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c30bcc1) 88.61% compared to head (481bb9a) 88.59%.

❗ Current head 481bb9a differs from pull request most recent head 9bb3d09. Consider uploading reports for the commit 9bb3d09 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   88.61%   88.59%   -0.03%     
==========================================
  Files          17       17              
  Lines         562      561       -1     
==========================================
- Hits          498      497       -1     
  Misses         64       64              
Flag Coverage Δ
main 74.50% <ø> (+0.13%) ⬆️
ngr 72.54% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl requested review from matriv and WalBeh November 22, 2023 22:21
@amotl amotl marked this pull request as ready for review November 22, 2023 22:21
Base automatically changed from maintain-dependencies to main November 22, 2023 22:28
Copy link

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to run a gradle task here? like ./gradlew build?

pueblo/ngr/runner.py Show resolved Hide resolved
@amotl amotl requested a review from matriv November 23, 2023 14:33
The Gradle test runner failed to invoke `./gradlew install`, because
such a target did not exist.
@amotl amotl force-pushed the amo/ngr-fix-gradle branch from 481bb9a to 9bb3d09 Compare November 23, 2023 20:57
@amotl amotl merged commit 4f47844 into main Nov 23, 2023
4 checks passed
@amotl amotl deleted the amo/ngr-fix-gradle branch November 23, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants