-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backends in flash_attention and gemm #58
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
had a problem deploying
to
docker-s3-upload
November 19, 2024 23:54 — with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
November 19, 2024 23:57 — with
GitHub Actions
Error
xuzhao9
temporarily deployed
to
docker-s3-upload
November 20, 2024 00:01 — with
GitHub Actions
Inactive
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2024 00:09 — with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2024 00:14 — with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2024 00:16 — with
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2024 00:28 — with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2024 00:31 — with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2024 00:32 — with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2024 00:33 — with
GitHub Actions
Failure
xuzhao9
changed the title
Fix pt2-cutlass gemm backend
Fix backends in flash_attention and gemm
Nov 20, 2024
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2024 00:43 — with
GitHub Actions
Failure
xuzhao9
temporarily deployed
to
docker-s3-upload
November 20, 2024 00:51 — with
GitHub Actions
Inactive
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
FindHao
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xuzhao9
had a problem deploying
to
docker-s3-upload
November 20, 2024 18:05 — with
GitHub Actions
Failure
xuzhao9
force-pushed
the
xz9/fix-pt2-cutlass
branch
from
November 20, 2024 18:58
37fc98c
to
f54c49d
Compare
xuzhao9
temporarily deployed
to
docker-s3-upload
November 20, 2024 18:58 — with
GitHub Actions
Inactive
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run PT2 cutlass backend, we have to add a cutlass submodule that has the same version as pytorch: https://github.com/pytorch/pytorch/tree/main/third_party
The version points to
https://github.com/NVIDIA/cutlass/tree/bbe579a9e3beb6ea6626d9227ec32d0dae119a49 which is 9 months old.
The FBGEMM cutlass is much newer.
Test plan:
Fixes #17