Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes for Python 3.13 #206

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Test fixes for Python 3.13 #206

merged 5 commits into from
Oct 2, 2024

Conversation

opoplawski
Copy link

This is basically a port of [email protected]:opoplawski/cytoolz.git

Python upstream recently fixed the behavior of inspect with
wrappers: python/cpython#112006 . The
assertion here relies on the broken behavior, we only get None
if `inspect(Wrapped)` fails and raises `ValueError`. Now it
works, we actually get the correct answer, 1. This changes it so
we assert the correct thing depending on the Python version (the
fix was backported to 3.11.9 and 3.12.3, so the check has to be a
bit complicated).
dopplershift added a commit to regro-cf-autotick-bot/cytoolz-feedstock that referenced this pull request Sep 25, 2024
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @opoplawski. FWIW we can ignore the Python 3.7 failures here (about to drop support for that anyways)

@jrbourbeau jrbourbeau merged commit 946c198 into pytoolz:master Oct 2, 2024
52 of 60 checks passed
@jrbourbeau jrbourbeau mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants