Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run CI on python=3.13 #9681

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+6 −3
Open

run CI on python=3.13 #9681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
196af5d
don't install `dask`
keewis Oct 25, 2024
d5f86b8
don't install `pydap`
keewis Oct 25, 2024
98cadef
run CI on python 3.13
keewis Oct 25, 2024
b51957e
same for windows
keewis Oct 25, 2024
ddda851
classifier
keewis Oct 25, 2024
592695c
Merge branch 'main' into py313
keewis Oct 25, 2024
b5f7c61
whats-new
keewis Oct 25, 2024
dba0ae8
Merge branch 'main' into py313
keewis Nov 22, 2024
df216f5
fix bad merge
keewis Nov 22, 2024
3e98ddf
try installing `dask` + `distributed`
keewis Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
matrix:
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
# Bookend python versions
python-version: ["3.10", "3.12"]
python-version: ["3.10", "3.12", "3.13"]
Copy link
Contributor

@dcherian dcherian Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we just stick to all-but-dask given what we've had to comment out? If we're going to change this line, it'd be nice to drop 3.12 which we can't at the moment...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah dask/dask#11456 was just merged so this is coming...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in the progress of checking whether that's still necessary. If yes, then sure.

Copy link
Collaborator Author

@keewis keewis Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, looks like this will still fail, but not for long. I don't think we can go with all-but-dask, though, since that's still trying to install numba / sparse / numbagg. Until that supports python=3.13 we'll have to live with 3 more CI jobs, I guess.

Edit: looks like we don't need whatever blocked dask from officially supporting python=3.13 (CI seems to pass?)

env: [""]
include:
# Minimum python version:
Expand Down
2 changes: 1 addition & 1 deletion ci/requirements/environment-3.13.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dependencies:
- pip
- pooch
- pre-commit
- pydap
# - pydap
- pytest
- pytest-cov
- pytest-env
Expand Down
2 changes: 1 addition & 1 deletion ci/requirements/environment-windows-3.13.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ dependencies:
# - pint>=0.22
- pip
- pre-commit
- pydap
# - pydap
- pytest
- pytest-cov
- pytest-env
Expand Down
2 changes: 2 additions & 0 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ Benoit Bovy, Deepak Cherian, Dimitri Papadopoulos Orfanos, Holly Mandel, James B

New Features
~~~~~~~~~~~~
- support python 3.13 (no free-threading) (:issue:`9664`, :pull:`9681`)
By `Justus Magin <https://github.com/keewis>`_.
- Added :py:meth:`DataTree.persist` method (:issue:`9675`, :pull:`9682`).
By `Sam Levang <https://github.com/slevang>`_.
- Added ``write_inherited_coords`` option to :py:meth:`DataTree.to_netcdf`
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ classifiers = [
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Topic :: Scientific/Engineering",
]
description = "N-D labeled arrays and datasets in Python"
Expand Down
Loading