Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run CI on python=3.13 #9681

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

run CI on python=3.13 #9681

wants to merge 10 commits into from

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Oct 25, 2024

Missing libraries:

  • dask: dask-expr depends on pyarrow, which will support 3.13 starting with pyarrow>=18.0
  • pydap: depends on webob which uses the removed cgi stdlib (see Resolve Deprecation Warnings  pydap/pydap#319 (comment) in the "out-of-scope" section)
  • numba: as usual will take some time to support it (and thus we can't test numbagg and sparse)

reason: `dask-expr` depends on `pyarrow`, which doesn't support python
3.13 yet
reason: depends on `webob`, which makes use of `cgi`, a stdlib that got
removed in python 3.13
@keewis
Copy link
Collaborator Author

keewis commented Oct 25, 2024

Interestingly it's conda that you can't install along with python=3.13, but cftime, pandas, and possibly h5py also raise errors (I can't reproduce that locally, though). So I guess we'll have to revisit this in a couple of weeks.

@mathause
Copy link
Collaborator

Is there a reason we are installing conda? For the output of conda info and conda list? There is a micromamba info and micromamba list output in the Setup micromamba step which we could refer to instead.

@keewis
Copy link
Collaborator Author

keewis commented Nov 2, 2024

we use conda to call conda info -a, which contains information micromamba info does not include (and I don't know whether micromamba info -a exists). In theory we could use mamba info -a as well, but that also doesn't provide packages for python 3.13.

@@ -47,7 +47,7 @@ jobs:
matrix:
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
# Bookend python versions
python-version: ["3.10", "3.12"]
python-version: ["3.10", "3.12", "3.13"]
Copy link
Contributor

@dcherian dcherian Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we just stick to all-but-dask given what we've had to comment out? If we're going to change this line, it'd be nice to drop 3.12 which we can't at the moment...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah dask/dask#11456 was just merged so this is coming...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in the progress of checking whether that's still necessary. If yes, then sure.

Copy link
Collaborator Author

@keewis keewis Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, looks like this will still fail, but not for long. I don't think we can go with all-but-dask, though, since that's still trying to install numba / sparse / numbagg. Until that supports python=3.13 we'll have to live with 3 more CI jobs, I guess.

Edit: looks like we don't need whatever blocked dask from officially supporting python=3.13 (CI seems to pass?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add python 3.13 to CI
3 participants