Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add AndEsterson as a contributor for infra #4666

Closed
wants to merge 5 commits into from

Conversation

allcontributors[bot]
Copy link
Contributor

Adds @AndEsterson as a contributor for infra.

This was requested by Saransh-cpp in this comment

[skip ci]

Saransh-cpp
Saransh-cpp previously approved these changes Dec 12, 2024
@agriyakhetarpal agriyakhetarpal enabled auto-merge (squash) December 12, 2024 11:55
@agriyakhetarpal
Copy link
Member

The "style" status check shouldn't really be set to required because commits that skip all CI jobs (such as this one) won't be possible to merge otherwise.

@agriyakhetarpal
Copy link
Member

Someone with administrator permissions will need to merge this 🙂

@Saransh-cpp
Copy link
Member

The "style" status check shouldn't really be set to required because commits that skip all CI jobs (such as this one) won't be possible to merge otherwise.

Oh yes. @kratman could maybe help with this as Ferran is vacationing.

@kratman
Copy link
Contributor

kratman commented Dec 12, 2024

Style checks should be required. We should require as many checks as possible.

I will see if I can find a work around for this bot

@kratman
Copy link
Contributor

kratman commented Dec 12, 2024

I put up a fix PR for this, we might need to re-create this PR to fully tests it though

@kratman kratman deleted the all-contributors/add-AndEsterson branch December 12, 2024 13:04
@Saransh-cpp Saransh-cpp restored the all-contributors/add-AndEsterson branch December 12, 2024 13:04
@Saransh-cpp Saransh-cpp reopened this Dec 12, 2024
@Saransh-cpp
Copy link
Member

We will have to wait for another automated PR to test the infrastructure - see #4661 (comment)

README.md Outdated Show resolved Hide resolved
@Saransh-cpp Saransh-cpp deleted the all-contributors/add-AndEsterson branch December 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants