Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed dispatch-action for repository-dispatch (#4643) #4661

Merged

Conversation

AndEsterson
Copy link
Contributor

Description

Migrates .github/workflows/validation_benchmarks.yml from mvasigh/dispatch-action to peter-evans/repository-dispatch. There are some minor differences in syntax between these two GHAs, which should all be handled by this PR

Fixes #4643

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@AndEsterson AndEsterson force-pushed the issue-4643-repo-dispatch branch from cfb95ff to 1a7101d Compare December 11, 2024 16:01
Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AndEsterson! I would have suggested that we try it on your fork first to confirm the change, but doing it without setting up multiple tokens and repositories/forks is tricky. We could merge this and check if this is adequate, because the workflow is also triggered by pushes to develop.

@Saransh-cpp, does this look alright to you?

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked validation repo's CI and this should work. Thanks, @AndEsterson!

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (72c23ea) to head (fdc8570).
Report is 19 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4661   +/-   ##
========================================
  Coverage    99.21%   99.21%           
========================================
  Files          302      302           
  Lines        22858    22878   +20     
========================================
+ Hits         22679    22699   +20     
  Misses         179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agriyakhetarpal agriyakhetarpal merged commit 7b4c89b into pybamm-team:develop Dec 12, 2024
26 checks passed
@Saransh-cpp
Copy link
Member

@all-contributors please add @AndEsterson for infra

Copy link
Contributor

@Saransh-cpp

I've put up a pull request to add @AndEsterson! 🎉

@Saransh-cpp
Copy link
Member

@all-contributors please add @AndEsterson for infra

Copy link
Contributor

@Saransh-cpp

@AndEsterson already contributed before to infra

@Saransh-cpp
Copy link
Member

Ahhh

@Saransh-cpp
Copy link
Member

Trying this once more, sorry for the extra pings 😬

@Saransh-cpp
Copy link
Member

@all-contributors please add @AndEsterson for infra

Copy link
Contributor

@Saransh-cpp

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 44

@AndEsterson
Copy link
Contributor Author

thanks everyone for handling the merge! (and for being happy to do it without a full mock setup beforehand 😅 )

@Saransh-cpp
Copy link
Member

@all-contributors please add @AndEsterson for infra

Copy link
Contributor

@Saransh-cpp

I've put up a pull request to add @AndEsterson! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dispatch-action is no longer maintained
4 participants