-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed dispatch-action for repository-dispatch (#4643) #4661
changed dispatch-action for repository-dispatch (#4643) #4661
Conversation
cfb95ff
to
1a7101d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @AndEsterson! I would have suggested that we try it on your fork first to confirm the change, but doing it without setting up multiple tokens and repositories/forks is tricky. We could merge this and check if this is adequate, because the workflow is also triggered by pushes to develop
.
@Saransh-cpp, does this look alright to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rechecked validation repo's CI and this should work. Thanks, @AndEsterson!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4661 +/- ##
========================================
Coverage 99.21% 99.21%
========================================
Files 302 302
Lines 22858 22878 +20
========================================
+ Hits 22679 22699 +20
Misses 179 179 ☔ View full report in Codecov by Sentry. |
@all-contributors please add @AndEsterson for infra |
I've put up a pull request to add @AndEsterson! 🎉 |
@all-contributors please add @AndEsterson for infra |
@AndEsterson already contributed before to infra |
Ahhh |
Trying this once more, sorry for the extra pings 😬 |
@all-contributors please add @AndEsterson for infra |
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 44 |
thanks everyone for handling the merge! (and for being happy to do it without a full mock setup beforehand 😅 ) |
@all-contributors please add @AndEsterson for infra |
I've put up a pull request to add @AndEsterson! 🎉 |
Description
Migrates
.github/workflows/validation_benchmarks.yml
frommvasigh/dispatch-action
topeter-evans/repository-dispatch
. There are some minor differences in syntax between these two GHAs, which should all be handled by this PRFixes #4643
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest
(or$ nox -s tests
)$ python -m pytest --doctest-plus src
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks: