Fix PF provider_server detailed diff handling

[VenelinMartinov]

This change fixes an issue with the provider_server implementation's detailed diff handling. Previously passing a detailed diff to it would result in the previews being deleted. This is tested as part of #2629

The problem was that we were re-calculating the diffs and replaces keys for the GRPC Diff protocol in the provider_server implementation but also doing that incorrectly. Instead this change now makes provider_server's marshalDiff just pass through the diffs and replaces which we have already calculated in

pulumi-terraform-bridge/pkg/pf/tfbridge/provider_diff.go

Lines 108 to 109 in 1d6b032

	replaceKeys := topLevelPropertyKeySet(resSchemaMap, resFields, planResp.RequiresReplace)
	changedKeys := topLevelPropertyKeySet(resSchemaMap, resFields, diffAttributePaths(tfDiff))

fixes #2620

[VenelinMartinov]

This change is part of the following stack:

• Fix PF provider_server detailed diff handling #2628 ◀
  • PF detailed diff #2629
    • Add PF provider options and accurate previews flag #2663
      • Detailed diff handle secrets and outputs #2643
        • Add detailed diff recordings to PF diff tests #2657

_{Change managed by git-spice.}

[codecov]

Codecov Report

Attention: Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.

Project coverage is 69.39%. Comparing base (bc33162) to head (12bb0f7).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/pf/internal/plugin/provider_server.go	61.76%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2628      +/-   ##
==========================================
+ Coverage   69.35%   69.39%   +0.03%     
==========================================
  Files         301      301              
  Lines       38558    38560       +2     
==========================================
+ Hits        26743    26759      +16     
+ Misses      10295    10281      -14     
  Partials     1520     1520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[iwahbe]

This is code that is copied over from pulumi/.../plugin, so I'm hesitant to change it. Can we delegate to upstream's implementation?

Also, this change needs tests in this PR. For stacked PRs, each PR still needs to be atomically OK.

[VenelinMartinov]

We already have changes to our copy, so resolving the divergence is out of scope here. Getting rid of our copy is blocked on the config encoding work. The upstream copy does not seem to work correctly for the detailed diff either but is only used in tests.

EDIT: Added some unit tests. The tests in #2629 should add quite broad coverage here. I have separated this into a different PR to make reviewing easier.

[t0yv0]

Very surprised but this seems to hold?

https://github.com/search?q=org%3Apulumi%20plugin.NewProviderServer&type=code

Looks like these are mostly non-production uses.

[t0yv0]

Can you point out which line had the bug you're fixing? Very non-obvious.

[t0yv0]

I'm inclined to get this in given your finding that this Core code is not in prod anywhere. We need to maintain a working copy then. Oof. Please address the enum cast concern the rest are nits.

[VenelinMartinov]

Can you point out which line had the bug you're fixing? Very non-obvious.

The fix is really here - diffs and replaces should be top-level keys, which we already calculate before coming here. The meat of this change is to use these instead of re-calculating these incorrectly.
@t0yv0

[t0yv0]

🚢

[iwahbe]

Please open a bug in core so they can make this change upstream.