PF Diff cross-tests for computed set attributes #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Nov 19, 2024
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2639 +/- ##
=======================================
Coverage 69.97% 69.97%
=======================================
Files 367 367
Lines 44503 44503
=======================================
Hits 31140 31140
Misses 11734 11734
Partials 1629 1629 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
VenelinMartinov
force-pushed
the
vvm/pf_cross_tests_for_computed_in_sets
branch
from
02da7bc
to
3e81b9c
Compare
VenelinMartinov
force-pushed
the
pf-cross-tests-for-computed-set
branch
from
a01b833
to
7ecd0a5
Compare
VenelinMartinov
changed the title
t0yv0
reviewed
Nov 20, 2024
| ~ resource "testprovider_test" "res" { | ||
| id = "test-id" | ||
| ~ key = [ | ||
| + "val2", |
t0yv0
reviewed
Nov 20, 2024
| [urn=urn:pulumi:test::project::testprovider:index/test:Test::p] | ||
| ~ keys: [ | ||
| [0]: "val1" | ||
| ~ [1]: "val3" => "val2" |
There was a problem hiding this comment.
This made me squint but it makes sense.
t0yv0
approved these changes
Nov 20, 2024
Base automatically changed from
vvm/pf_cross_tests_for_computed_in_sets
to
master
November 20, 2024 17:37
VenelinMartinov
force-pushed
the
pf-cross-tests-for-computed-set
branch
from
7ecd0a5
to
fd5a1e8
Compare
VenelinMartinov
added a commit
that referenced
this pull request
Nov 20, 2024
|
This PR has been shipped in release v3.96.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cross-tests for computed set attributes in PF. Similar to #2638 but for set attributes, not blocks.