Add search control to LEL's basic usage #369 Commit

[robin-natale]

Fixes #369 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

[crisner]

@robin-natale, it looks like you have created a pull request from your master branch? To make sure we don't have conflicts when you work on other issues could you make a pull request from a new branch? Here's a link that might help understand why it is is recommended to do so. https://blog.jasonmeridth.com/posts/do-not-issue-pull-requests-from-your-master-branch/

[crisner]

All changes look good! 🎉
@robin-natale, could you also add a space between the word 'fixes' and the issue number so that it links correctly? Thanks!

[robin-natale]

Hi @crisner i will have a look at the documentation you sent me as i think I did not get it properly on how to merge from a new branch! 👍

[crisner]

I have shared some links here #391 (comment). This should help to get you started in the right direction.

[crisner]

@robin-natale, your branch seems to be missing. Could you close this PR and start a new one with a branch that is aptly named? Thanks! 😃

[jywarren]

Hmm, this is odd. @robin-natale @crisner we can still see the changes in this PR, but... let's try to find the original branch too? @crisner what if we just merged this, would that work?

[crisner]

@jywarren, I tried pulling the changes locally and it seems to work. The changes were made to @robin-natale's cloned repo's master branch and this had polluted PR #406 by @robin-natale for another FTO which was why I had requested some changes. The original repo has probably been removed.

[jywarren]

OK, great. I'm going to merge this and let's test it out one more time. Thanks!

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://publiclab.github.io/leaflet-environmental-layers/example/ in the next few days.
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

[jywarren]

🎉 🎉 🎉 🎉

[jywarren]

Just noting that I added search deps to plots2 here: publiclab/plots2@a3381b4

[jywarren]

nice:

Probably:

js:64 Google Maps JavaScript API error: RefererNotAllowedMapError
https://developers.google.com/maps/documentation/javascript/error-messages#referer-not-allowed-map-error
Your site URL to be authorized: https://stable.publiclab.org/map/#6/41/-71