Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds broken by "undefined is not a constructor (evaluating 'new L.Control.GPlaceAutocomplete" #451

Closed
jywarren opened this issue Apr 21, 2020 · 6 comments · Fixed by #454
Labels
bug Something isn't working help wanted Extra attention is needed testing

Comments

@jywarren
Copy link
Member

We're now seeing this error in tests possibly due to #404 -- when location searching was added using L.Control.GPlaceAutocomplete

https://travis-ci.com/github/publiclab/leaflet-environmental-layers/builds/154813074

     TypeError: undefined is not a constructor (evaluating 'new L.Control.GPlaceAutocomplete') in file:///home/travis/build/publiclab/leaflet-environmental-layers/dist/LeafletEnvironmentalLayers_babel.js (line 5139) (1)
   - include specific layers...X include specific layers

I think maybe we have to add the JS include to our test fixtures?

@jywarren
Copy link
Member Author

Yes should need:

  <script src="../node_modules/leaflet-google-places-autocomplete/src/js/leaflet-gplaces-autocomplete.js"></script>
  <link rel="stylesheet" href="../node_modules/leaflet-google-places-autocomplete/src/css/leaflet-gplaces-autocomplete.css">
  <script src="https://maps.googleapis.com/maps/api/js?key=AIzaSyAOLUQngEmJv0_zcG1xkGq-CXIPpLQY8iQ&libraries=places"></script>

@jywarren jywarren added bug Something isn't working help wanted Extra attention is needed testing labels Apr 21, 2020
@jywarren
Copy link
Member Author

Actually i think it may be required here instead or also:

I'll add it there too so we can see.

@jywarren
Copy link
Member Author

Moving discussion to PR

@jywarren
Copy link
Member Author

I definitely need help here, just in case anyone happens to drop by! ❤️

@jywarren
Copy link
Member Author

jywarren commented May 5, 2020

THANK YOU @crisner !!! 🙌 and hope you're well!!

@crisner
Copy link
Contributor

crisner commented May 6, 2020

🙌 😃 Yes, I am well, thank you @jywarren! I hope you are well too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed testing
Projects
None yet
2 participants