-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds broken by "undefined is not a constructor (evaluating 'new L.Control.GPlaceAutocomplete" #451
Comments
Yes should need: <script src="../node_modules/leaflet-google-places-autocomplete/src/js/leaflet-gplaces-autocomplete.js"></script>
<link rel="stylesheet" href="../node_modules/leaflet-google-places-autocomplete/src/css/leaflet-gplaces-autocomplete.css">
<script src="https://maps.googleapis.com/maps/api/js?key=AIzaSyAOLUQngEmJv0_zcG1xkGq-CXIPpLQY8iQ&libraries=places"></script> |
Actually i think it may be required here instead or also: leaflet-environmental-layers/Gruntfile.js Line 59 in f4a2e68
I'll add it there too so we can see. |
Moving discussion to PR |
I definitely need help here, just in case anyone happens to drop by! ❤️ |
THANK YOU @crisner !!! 🙌 and hope you're well!! |
🙌 😃 Yes, I am well, thank you @jywarren! I hope you are well too! |
We're now seeing this error in tests possibly due to #404 -- when location searching was added using
L.Control.GPlaceAutocomplete
https://travis-ci.com/github/publiclab/leaflet-environmental-layers/builds/154813074
I think maybe we have to add the JS include to our test fixtures?
The text was updated successfully, but these errors were encountered: