Add basic bed leveling screen to Calibration menu #2438
Conversation
martin357
force-pushed
the
BFW-2586_inconsistent_MBL
branch
from
9193e81
to
22a9df3
Compare
src/gui/screen_bed_leveling.cpp
Outdated
| const uint8_t *data = reinterpret_cast<const uint8_t *>(msg); | ||
| auto newText = string_view_utf8::MakeRAM(data); | ||
| if (newText != this->m_statusMsg.GetText()) { | ||
| this->m_statusMsg.SetText(newText); |
There was a problem hiding this comment.
The data could change under our hands between the call and invalidate.
MakeRAM does not allocate any memory, it uses the memory where the pointer points.
There was a problem hiding this comment.
This should be fixed by keeping an internal copy.
src/gui/screen_bed_leveling.hpp
Outdated
|
|
||
| /** While an instance exists, MenuTimeout will be disabled. | ||
| **/ | ||
| class MenuTimeoutBlocker { |
There was a problem hiding this comment.
Just call DisableMenuTimeout() in constructor. and it will disable timeout for this screen. This object is not needed.
With Screens::Access() you get pinter to current screen
There was a problem hiding this comment.
Removed, switched to DisableMenuTimeout()
src/gui/screen_bed_leveling.hpp
Outdated
| #include "screen.hpp" | ||
| #include "ScreenHandler.hpp" | ||
|
|
||
| class screen_bed_leveling_t : public AddSuperWindow<screen_t> { |
There was a problem hiding this comment.
Use CamelCase for the name of the screen.
src/gui/screen_bed_leveling.cpp
Outdated
| , footer(this) { | ||
| header.SetIcon(IDR_PNG_heatbed_16px); | ||
| header.SetText(_("BED LEVELING")); | ||
| this->m_statusMsg.SetText(_("")); |
There was a problem hiding this comment.
Text will be initialized as empty, but if you want use directly stringview insted of translating empty string.
martin357
force-pushed
the
BFW-2586_inconsistent_MBL
branch
from
22a9df3
to
a2f2952
Compare
- Use screen_t as ancestor and get the last marlin message localy from the screen - Block MenuTimeout when Mesh Bed Leveling is in progress - Add progressBar BFW-2586
martin357
force-pushed
the
BFW-2586_inconsistent_MBL
branch
from
a2f2952
to
c0d8435
Compare
BFW-2586