Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark v1.20.0-rc4 #2203

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Mark v1.20.0-rc4 #2203

merged 1 commit into from
Oct 25, 2024

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Oct 25, 2024

Description

This PR marks v1.20.0-rc4 in main.

It's basically a frontport of this PR:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Added relevant changelog entries under .changelog/unreleased (see Adding Changes).
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Summary by CodeRabbit

Release Notes for Version v1.20.0-rc4

  • New Features

    • Enhanced querying for metadata records with improved command functionality.
    • Added query flags to the query wasm build-addr command for better usability.
  • Improvements

    • Configuration for consensus timeout has been set to 3.5 seconds for the mainnet.
    • Updated prep-release script to streamline dependency changelog entries.
    • Specification documentation links have been updated to reference version v1.20.0.
    • Suppressed events during the metadata migration for a cleaner process.
  • Bug Fixes

    • Registered parameter types to ensure compatibility with older governance properties.

# Conflicts:
#	RELEASE_CHANGELOG.md
@SpicyLemon SpicyLemon requested a review from a team as a code owner October 25, 2024 15:41
Copy link
Contributor

coderabbitai bot commented Oct 25, 2024

Walkthrough

This pull request involves the deletion of several changelog files documenting various improvements and bug fixes related to command functionalities and configuration settings. Key changes include updates to the query metadata recordspec command, governance properties handling, and the query wasm build-addr command. Additionally, the CHANGELOG.md file is updated to reflect a new release entry for version v1.20.0-rc4, summarizing these changes and linking to the full commit history.

Changes

File Path Change Summary
.changelog/unreleased/bug-fixes/2148-fix-recordspec-cli.md Deleted entry documenting the fix for the query metadata recordspec command.
.changelog/unreleased/bug-fixes/2198-fix-gov-props.md Deleted entry indicating registration of parameter types for reading old governance properties.
.changelog/unreleased/bug-fixes/2199-fix-wasm-build-addr.md Deleted entry documenting the addition of query flags to the query wasm build-addr command.
.changelog/unreleased/improvements/2121-commit-timeout.md Deleted entry regarding the removal of hardcoded consensus.timeout_commit value for mainnet.
.changelog/unreleased/improvements/2181-combine-changelog-dep-lines.md Deleted entry about the update to the prep-release script for combining dependency changelog entries.
.changelog/unreleased/improvements/2192-use-v1-20-0-in-spec-links.md Deleted entry documenting update of proto file links to version v1.20.0.
.changelog/unreleased/improvements/2195-hide-md-mig-events.md Deleted entry about suppressing events during metadata migration.
CHANGELOG.md Updated to include new release entry for version v1.20.0-rc4, summarizing improvements and bug fixes.

Possibly related PRs

Suggested reviewers

  • scirner22
  • iramiller

Poem

In the land of code where rabbits play,
We fixed the queries, hip-hip-hooray!
With changelogs bright, our work is done,
Enhancements made, oh what fun!
So hop along, let’s celebrate,
For every fix, we elevate! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

72-73: Consider formatting bare URLs as markdown links.

The commit history comparison URLs should be formatted as markdown links for better readability and consistency with the rest of the document.

-* https://github.com/provenance-io/provenance/compare/v1.20.0-rc3...v1.20.0-rc4
-* https://github.com/provenance-io/provenance/compare/v1.19.1...v1.20.0-rc4
+* [v1.20.0-rc3...v1.20.0-rc4](https://github.com/provenance-io/provenance/compare/v1.20.0-rc3...v1.20.0-rc4)
+* [v1.19.1...v1.20.0-rc4](https://github.com/provenance-io/provenance/compare/v1.19.1...v1.20.0-rc4)
🧰 Tools
🪛 Markdownlint

72-72: null
Bare URL used

(MD034, no-bare-urls)


73-73: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3f35d38 and c1002fd.

📒 Files selected for processing (8)
  • .changelog/unreleased/bug-fixes/2148-fix-recordspec-cli.md (0 hunks)
  • .changelog/unreleased/bug-fixes/2198-fix-gov-props.md (0 hunks)
  • .changelog/unreleased/bug-fixes/2199-fix-wasm-build-addr.md (0 hunks)
  • .changelog/unreleased/improvements/2121-commit-timeout.md (0 hunks)
  • .changelog/unreleased/improvements/2181-combine-changelog-dep-lines.md (0 hunks)
  • .changelog/unreleased/improvements/2192-use-v1-20-0-in-spec-links.md (0 hunks)
  • .changelog/unreleased/improvements/2195-hide-md-mig-events.md (0 hunks)
  • CHANGELOG.md (1 hunks)
💤 Files with no reviewable changes (7)
  • .changelog/unreleased/bug-fixes/2148-fix-recordspec-cli.md
  • .changelog/unreleased/bug-fixes/2198-fix-gov-props.md
  • .changelog/unreleased/bug-fixes/2199-fix-wasm-build-addr.md
  • .changelog/unreleased/improvements/2121-commit-timeout.md
  • .changelog/unreleased/improvements/2181-combine-changelog-dep-lines.md
  • .changelog/unreleased/improvements/2192-use-v1-20-0-in-spec-links.md
  • .changelog/unreleased/improvements/2195-hide-md-mig-events.md
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md

72-72: null
Bare URL used

(MD034, no-bare-urls)


73-73: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (1)
CHANGELOG.md (1)

55-74: LGTM! Well-structured changelog entry.

The v1.20.0-rc4 changelog entry is well organized with:

  • Clear version number and date
  • Properly categorized changes under Improvements and Bug Fixes
  • Links to relevant PRs and issues
  • Full commit history references
🧰 Tools
🪛 Markdownlint

72-72: null
Bare URL used

(MD034, no-bare-urls)


73-73: null
Bare URL used

(MD034, no-bare-urls)

@SpicyLemon SpicyLemon enabled auto-merge (squash) October 25, 2024 16:13
@SpicyLemon SpicyLemon merged commit ea7e275 into main Oct 25, 2024
20 checks passed
@SpicyLemon SpicyLemon deleted the dwedul/main-v1.20.0-rc4 branch October 25, 2024 16:28
@coderabbitai coderabbitai bot mentioned this pull request Oct 28, 2024
8 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 7, 2024
8 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 21, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants