Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark v1.20.0 #2205

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Mark v1.20.0 #2205

merged 1 commit into from
Oct 28, 2024

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Oct 28, 2024

Description

This PR marks v1.20.0 in the changelog on the main branch.

It's basically a frontport of:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Added relevant changelog entries under .changelog/unreleased (see Adding Changes).
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Summary by CodeRabbit

  • New Features

    • Introduced the viridian upgrade.
  • Improvements

    • Updated the consensus.timeout_commit config value to 3.5 seconds.
    • Enhanced the prep-release script to consolidate dependency changelog entries.
  • Bug Fixes

    • Resolved issues with the query metadata recordspec command and improved registration of params types.
  • Breaking Changes

    • Removed old provwasm bindings and modified the Ownership query behavior.
  • Dependencies

    • Updated bufbuild/buf-setup-action to version 1.45.0 and other library dependencies.

* Mark v1.20.0

* Add a little more to the summary.
# Conflicts:
#	.changelog/v1.20.0/api-breaking/2137-bank-scope-value-owners.md
#	.changelog/v1.20.0/api-breaking/2176-delete-params.md
#	.changelog/v1.20.0/bug-fixes/2110-marker-feegrant-fix.md
#	.changelog/v1.20.0/bug-fixes/2135-openapiv2.md
#	.changelog/v1.20.0/bug-fixes/2144-remove-metadata-count-telemetry.md
#	.changelog/v1.20.0/bug-fixes/2148-fix-recordspec-cli.md
#	.changelog/v1.20.0/bug-fixes/2177-add-store-telemetry.md
#	.changelog/v1.20.0/bug-fixes/2182-fix-release-changelog.md
#	.changelog/v1.20.0/bug-fixes/2184-fix-heighliner.md
#	.changelog/v1.20.0/bug-fixes/2189-remove-params-storekey.md
#	.changelog/v1.20.0/bug-fixes/2198-fix-gov-props.md
#	.changelog/v1.20.0/bug-fixes/2199-fix-wasm-build-addr.md
#	.changelog/v1.20.0/bug-fixes/376-fix-markdown-gen.md
#	.changelog/v1.20.0/client-breaking/2119-remove-deprecated-bindings.md
#	.changelog/v1.20.0/client-breaking/2153-keccak.md
#	.changelog/v1.20.0/client-breaking/2158-fix-metadata-nav-example.md
#	.changelog/v1.20.0/dependencies/2100-cosmossdk-io-client-v2-2-0-0-beta-4.md
#	.changelog/v1.20.0/dependencies/2107-cosmossdk-io-core-0-11-1.md
#	.changelog/v1.20.0/dependencies/2113-cosmossdk-io-x-tx-0-13-4.md
#	.changelog/v1.20.0/dependencies/2114-github-com-spf13-cast-1-7-0.md
#	.changelog/v1.20.0/dependencies/2115-golang-org-x-text-0-17-0.md
#	.changelog/v1.20.0/dependencies/2116-cosmossdk-io-log-1-4-0.md
#	.changelog/v1.20.0/dependencies/2120-github-com-cometbft-cometbft-0-38-11.md
#	.changelog/v1.20.0/dependencies/2122-bufbuild-buf-setup-action-1-36-0.md
#	.changelog/v1.20.0/dependencies/2125-github-com-cosmos-gogoproto-1-7-0.md
#	.changelog/v1.20.0/dependencies/2126-github-com-cosmwasm-wasmvm-v2-2-1-2.md
#	.changelog/v1.20.0/dependencies/2129-cosmossdk-io-log-1-4-1.md
#	.changelog/v1.20.0/dependencies/2130-cosmossdk-io-core-0-11-2.md
#	.changelog/v1.20.0/dependencies/2131-bufbuild-buf-setup-action-1-37-0.md
#	.changelog/v1.20.0/dependencies/2132-bump-go-to-1.23.md
#	.changelog/v1.20.0/dependencies/2133-bufbuild-buf-setup-action-1-38-0.md
#	.changelog/v1.20.0/dependencies/2138-bufbuild-buf-setup-action-1-39-0.md
#	.changelog/v1.20.0/dependencies/2141-peter-evans-create-pull-request-7-0-0.md
#	.changelog/v1.20.0/dependencies/2142-github-com-cometbft-cometbft-0-38-12.md
#	.changelog/v1.20.0/dependencies/2143-golang-org-x-text-0-18-0.md
#	.changelog/v1.20.0/dependencies/2150-google-golang-org-grpc-1-66-2.md
#	.changelog/v1.20.0/dependencies/2151-bufbuild-buf-setup-action-1-41-0.md
#	.changelog/v1.20.0/dependencies/2152-peter-evans-create-pull-request-7-0-2.md
#	.changelog/v1.20.0/dependencies/2153-cosmossdk-io-client-v2-2-0-0-beta-5.md
#	.changelog/v1.20.0/dependencies/2154-cosmossdk-io-x-tx-0-13-5.md
#	.changelog/v1.20.0/dependencies/2155-bufbuild-buf-setup-action-1-42-0.md
#	.changelog/v1.20.0/dependencies/2156-peter-evans-create-pull-request-7-0-5.md
#	.changelog/v1.20.0/dependencies/2157-google-golang-org-grpc-1-67-0.md
#	.changelog/v1.20.0/dependencies/2161-github-com-cosmwasm-wasmvm-v2-2-1-3.md
#	.changelog/v1.20.0/dependencies/2162-cosmossdk-io-api-0-7-6.md
#	.changelog/v1.20.0/dependencies/2164-bufbuild-buf-setup-action-1-43-0.md
#	.changelog/v1.20.0/dependencies/2165-google-golang-org-grpc-1-67-1.md
#	.changelog/v1.20.0/dependencies/2168-bufbuild-buf-setup-action-1-44-0.md
#	.changelog/v1.20.0/dependencies/2170-golang-org-x-text-0-19-0.md
#	.changelog/v1.20.0/dependencies/2173-google-golang-org-protobuf-1-35-1.md
#	.changelog/v1.20.0/dependencies/2174-bufbuild-buf-setup-action-1-45-0.md
#	.changelog/v1.20.0/dependencies/2175-bump-sdk-to-50-10.md
#	.changelog/v1.20.0/features/2137-bank-scope-value-owners.md
#	.changelog/v1.20.0/improvements/2030-explicit-navs.md
#	.changelog/v1.20.0/improvements/2062-build-debug.md
#	.changelog/v1.20.0/improvements/2112-switch-to-unclog.md
#	.changelog/v1.20.0/improvements/2121-commit-timeout.md
#	.changelog/v1.20.0/improvements/2128-marker-nav-docs.md
#	.changelog/v1.20.0/improvements/2134-metadata-nav-doc.md
#	.changelog/v1.20.0/improvements/2136-makefile-cleanup.md
#	.changelog/v1.20.0/improvements/2137-bank-scope-value-owners.md
#	.changelog/v1.20.0/improvements/2166-add-changelog-helper.md
#	.changelog/v1.20.0/improvements/2176-delete-umber.md
#	.changelog/v1.20.0/improvements/2181-combine-changelog-dep-lines.md
#	.changelog/v1.20.0/improvements/2192-use-v1-20-0-in-spec-links.md
#	.changelog/v1.20.0/improvements/2195-hide-md-mig-events.md
#	.changelog/v1.20.0/summary.md
#	RELEASE_CHANGELOG.md
@SpicyLemon SpicyLemon requested a review from a team as a code owner October 28, 2024 16:28
Copy link
Contributor

coderabbitai bot commented Oct 28, 2024

Walkthrough

The changes in this pull request involve the deletion of a file containing essential build and installation requirements for the provenanced project, specifically regarding Go and linting tool versions. Additionally, the CHANGELOG.md file has been significantly restructured to reflect a new release version, including updates to features, improvements, bug fixes, and breaking changes. The changelog now provides a clearer overview of the latest release's modifications and dependencies.

Changes

File Change Summary
.changelog/unreleased/summary.md Deleted file containing build and installation requirements for provenanced, including Go version and linting tool specifications.
CHANGELOG.md Restructured to indicate release version v1.20.0, added sections for features, improvements, bug fixes, and breaking changes; updated links and consolidated dependencies.

Possibly related PRs

  • When prepping a release, combine the dependency bump changelog entries. #2181: This PR updates the prep-release.sh script to combine dependency changelog entries, which is relevant to the changes in the main PR regarding build and installation requirements for the provenanced project.
  • Mark v1.20.0-rc4 #2203: This PR marks the release version v1.20.0-rc4 in the changelog, which includes updates related to the changelog structure and dependencies, connecting it to the main PR's focus on installation requirements and project setup.

Suggested reviewers

  • scirner22
  • Taztingo

Poem

🐇 In the meadow, changes bloom,
Changelog brightens, dispels the gloom.
Build tools updated, paths made clear,
With every hop, we bring good cheer!
From rc to release, we leap with glee,
In the world of code, we're wild and free! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SpicyLemon SpicyLemon enabled auto-merge (squash) October 28, 2024 16:29
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
CHANGELOG.md (2)

164-164: Consider using a proper link format for the URL.

Instead of using a bare URL, consider using the markdown link syntax for better readability and maintainability.

-* https://github.com/provenance-io/provenance/compare/v1.19.1...v1.20.0
+* [Full Commit History](https://github.com/provenance-io/provenance/compare/v1.19.1...v1.20.0)
🧰 Tools
🪛 Markdownlint

164-164: null
Bare URL used

(MD034, no-bare-urls)


164-164: Consider standardizing commit history link format.

For consistency, consider updating all commit history links to use proper markdown format. This would improve readability and maintainability across the changelog.

Example format:

-* https://github.com/provenance-io/provenance/compare/v1.19.1...v1.20.0
+* [Full Commit History](https://github.com/provenance-io/provenance/compare/v1.19.1...v1.20.0)

Also applies to: 341-341, 517-517, 676-676, 803-803, 1001-1001, 1261-1261

🧰 Tools
🪛 Markdownlint

164-164: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ea7e275 and 24890bf.

📒 Files selected for processing (2)
  • .changelog/unreleased/summary.md (0 hunks)
  • CHANGELOG.md (4 hunks)
💤 Files with no reviewable changes (1)
  • .changelog/unreleased/summary.md
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md

164-164: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (2)
CHANGELOG.md (2)

Line range hint 55-160: Well-structured version entries with clear categorization.

The changelog entries for v1.20.0 are well-organized with:

  • Clear categorization of changes (Features, Improvements, Bug Fixes, etc.)
  • Proper linking to issues and PRs
  • Detailed dependency updates with version changes

Line range hint 1-1261: Excellent changelog organization and clarity.

The changelog follows best practices:

  • Consistent formatting across versions
  • Clear marking of breaking changes
  • Detailed tracking of dependencies
  • Proper categorization of changes

@SpicyLemon SpicyLemon merged commit 72aaaa0 into main Oct 28, 2024
20 checks passed
@SpicyLemon SpicyLemon deleted the dwedul/main-v1.20.0 branch October 28, 2024 19:40
@coderabbitai coderabbitai bot mentioned this pull request Nov 7, 2024
8 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 21, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants