Mark v1.20.0-rc1 #2179
Merged
Mark v1.20.0-rc1 #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ummary back into unrleased.
…ion that the replace line is based on.
iramiller
reviewed
Oct 14, 2024
iramiller
approved these changes
Oct 14, 2024
scirner22
approved these changes
Oct 15, 2024
SpicyLemon
added a commit
that referenced
this pull request
Oct 15, 2024
* Fix sed command in prep-release that was causing minor version validation to fail. * At the end of prep-release, if it was a release candidate, copy the summary back into unrleased. * Reformat the go bump dependency entries to match the others. * Add a period messing from one of the changelog entries. * Update the version in the require entry for the sdk to match the version that the replace line is based on. * Mark v1.20.0-rc1.
SpicyLemon
added a commit
that referenced
this pull request
Oct 16, 2024
* Mark v1.20.0-rc1 (#2179) * Fix sed command in prep-release that was causing minor version validation to fail. * At the end of prep-release, if it was a release candidate, copy the summary back into unrleased. * Reformat the go bump dependency entries to match the others. * Update the version in the require entry for the sdk to match the version that the replace line is based on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
v1.20.0-rc1in the changelog and release notes onrelease/v1.20.x.prep-release.shscript to fix minor version validation (badsedcommand) and carry thesummary.mdforward for release candidates.go.modrequire entry for the sdk to have the version that our replace line for it is based on.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments..changelog/unreleased(see Adding Changes).Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.