Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark v1.20.0-rc1. #2180

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Mark v1.20.0-rc1. #2180

merged 4 commits into from
Oct 16, 2024

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Oct 15, 2024

Description

This PR updates the changelog in the main branch to reflect the release of v1.20.0-rc1.

It's basically a frontport of #2179 but with the release notes and applicable changelog entry files deleted.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Added relevant changelog entries under .changelog/unreleased (see Adding Changes).
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Summary by CodeRabbit

  • New Features

    • Introduced the viridian upgrade.
  • Improvements

    • NAV records will now only be set when explicitly provided.
    • Added a build-debug make target for easier debugging.
    • Transitioned to using unclog for unreleased changelog entries.
    • Addressed documentation gaps for marker and metadata navigation commands.
    • Cleaned up unused components in makefiles.
    • Bank module now tracks the value owner of scopes.
    • Created add-change.sh script for easier changelog entries.
    • Removed the unnecessary umber upgrade and its components.
  • Bug Fixes

    • Fixed proto markdown generation and regenerated related documentation.
    • Restored functionality for marker funds via feegrant.
    • Resolved issues with proto generation.
    • Removed non-functional telemetry counters from the metadata module.
    • Updated telemetry to include previously removed data from cometbft.
  • Client Breaking Changes

    • Removed deprecated provwasm bindings.
    • Updated HashOp enum value in proofs.proto from KECCAK to KECCAK256.
    • Corrected metadata nav CLI command example and added a volume parameter.
  • API Breaking Changes

    • Modified Ownership query to return only scopes where the address is an owner.
    • Updated WriteScope endpoint handling of scope.value_owner_address.
    • Separated authorization for MsgWriteScope from related endpoints.
    • Removed the params module and associated endpoints.
  • Dependencies

    • Updated multiple dependencies, including github.com/cosmos/cosmos-sdk from v0.50.7 to v0.50.10.

* Fix sed command in prep-release that was causing minor version validation to fail.

* At the end of prep-release, if it was a release candidate, copy the summary back into unrleased.

* Reformat the go bump dependency entries to match the others.

* Add a period messing from one of the changelog entries.

* Update the version in the require entry for the sdk to match the version that the replace line is based on.

* Mark v1.20.0-rc1.
@SpicyLemon SpicyLemon requested a review from a team as a code owner October 15, 2024 21:53
Copy link
Contributor

coderabbitai bot commented Oct 15, 2024

Walkthrough

The changes in this pull request involve multiple updates to the codebase, including enhancements to the prep-release.sh script for better handling of release candidates and improved error handling. Several files documenting changes, bug fixes, and dependency updates have been deleted, reflecting a cleanup of the changelog. Notably, the CHANGELOG.md has been updated to include a new version entry for v1.20.0-rc1, detailing features, improvements, bug fixes, and breaking changes. Additionally, the go.mod file has been modified to update the cosmos-sdk dependency version.

Changes

File Path Change Summary
.changelog/prep-release.sh Enhanced logic for release candidates, improved error handling, and added verbose output statements.
.changelog/unreleased/api-breaking/2137-bank-scope-value-owners.md Deleted file documenting changes to the Ownership query.
.changelog/unreleased/api-breaking/2176-delete-params.md Deleted file indicating the removal of the params module.
.changelog/unreleased/bug-fixes/2110-marker-feegrant-fix.md Deleted file indicating a fix for marker funds via feegrant.
.changelog/unreleased/bug-fixes/2135-openapiv2.md Deleted file documenting a fix related to proto generation.
.changelog/unreleased/bug-fixes/2144-remove-metadata-count-telemetry.md Deleted file noting the removal of non-functional telemetry counters.
.changelog/unreleased/bug-fixes/2177-add-store-telemetry.md Deleted file indicating an update to telemetry data from CometBFT.
.changelog/unreleased/dependencies/*.md Deleted files documenting various dependency updates.
CHANGELOG.md Updated for version v1.20.0-rc1, detailing features, improvements, bug fixes, and breaking changes.
go.mod Updated github.com/cosmos/cosmos-sdk dependency from v0.50.7 to v0.50.10.

Possibly related issues

Possibly related PRs

Suggested labels

dependencies, github_actions

Suggested reviewers

  • Taztingo
  • iramiller
  • nullpointer0x00

Poem

In the burrows deep and wide,
Changes hop with joyful pride.
Scripts refined, dependencies tall,
A new release, we heed the call!
With every fix, our code will thrive,
In the land of code, we come alive! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SpicyLemon SpicyLemon enabled auto-merge (squash) October 15, 2024 21:55
@SpicyLemon SpicyLemon disabled auto-merge October 15, 2024 21:55
@SpicyLemon SpicyLemon enabled auto-merge (squash) October 15, 2024 21:56
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

Line range hint 1-1938: Overall CHANGELOG.md structure and consistency

The CHANGELOG.md file maintains a good structure with separate sections for each release, including features, improvements, bug fixes, and breaking changes. This format is consistent throughout the file, which is excellent for readability and tracking changes over time.

To further improve the changelog:

  1. Consider adding a table of contents at the beginning for easier navigation, especially as the file grows.
  2. Ensure that all links to issues and pull requests are functioning correctly.
  3. Maintain consistent formatting for version headers and section titles across all entries.

Consider adding a table of contents at the beginning of the CHANGELOG.md file to improve navigation, especially for users looking for specific versions or changes.

🧰 Tools
🪛 Markdownlint

181-181: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 488b8a7 and c51bec9.

📒 Files selected for processing (59)
  • .changelog/prep-release.sh (2 hunks)
  • .changelog/unreleased/api-breaking/2137-bank-scope-value-owners.md (0 hunks)
  • .changelog/unreleased/api-breaking/2176-delete-params.md (0 hunks)
  • .changelog/unreleased/bug-fixes/2110-marker-feegrant-fix.md (0 hunks)
  • .changelog/unreleased/bug-fixes/2135-openapiv2.md (0 hunks)
  • .changelog/unreleased/bug-fixes/2144-remove-metadata-count-telemetry.md (0 hunks)
  • .changelog/unreleased/bug-fixes/2177-add-store-telemetry.md (0 hunks)
  • .changelog/unreleased/bug-fixes/376-fix-markdown-gen.md (0 hunks)
  • .changelog/unreleased/client-breaking/2119-remove-deprecated-bindings.md (0 hunks)
  • .changelog/unreleased/client-breaking/2153-keccak.md (0 hunks)
  • .changelog/unreleased/client-breaking/2158-fix-metadata-nav-example.md (0 hunks)
  • .changelog/unreleased/dependencies/2100-cosmossdk-io-client-v2-2-0-0-beta-4.md (0 hunks)
  • .changelog/unreleased/dependencies/2107-cosmossdk-io-core-0-11-1.md (0 hunks)
  • .changelog/unreleased/dependencies/2113-cosmossdk-io-x-tx-0-13-4.md (0 hunks)
  • .changelog/unreleased/dependencies/2114-github-com-spf13-cast-1-7-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2115-golang-org-x-text-0-17-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2116-cosmossdk-io-log-1-4-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2120-github-com-cometbft-cometbft-0-38-11.md (0 hunks)
  • .changelog/unreleased/dependencies/2122-bufbuild-buf-setup-action-1-36-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2125-github-com-cosmos-gogoproto-1-7-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2126-github-com-cosmwasm-wasmvm-v2-2-1-2.md (0 hunks)
  • .changelog/unreleased/dependencies/2129-cosmossdk-io-log-1-4-1.md (0 hunks)
  • .changelog/unreleased/dependencies/2130-cosmossdk-io-core-0-11-2.md (0 hunks)
  • .changelog/unreleased/dependencies/2131-bufbuild-buf-setup-action-1-37-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2132-bump-go-to-1.23.md (0 hunks)
  • .changelog/unreleased/dependencies/2133-bufbuild-buf-setup-action-1-38-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2138-bufbuild-buf-setup-action-1-39-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2141-peter-evans-create-pull-request-7-0-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2142-github-com-cometbft-cometbft-0-38-12.md (0 hunks)
  • .changelog/unreleased/dependencies/2143-golang-org-x-text-0-18-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2150-google-golang-org-grpc-1-66-2.md (0 hunks)
  • .changelog/unreleased/dependencies/2151-bufbuild-buf-setup-action-1-41-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2152-peter-evans-create-pull-request-7-0-2.md (0 hunks)
  • .changelog/unreleased/dependencies/2153-cosmossdk-io-client-v2-2-0-0-beta-5.md (0 hunks)
  • .changelog/unreleased/dependencies/2154-cosmossdk-io-x-tx-0-13-5.md (0 hunks)
  • .changelog/unreleased/dependencies/2155-bufbuild-buf-setup-action-1-42-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2156-peter-evans-create-pull-request-7-0-5.md (0 hunks)
  • .changelog/unreleased/dependencies/2157-google-golang-org-grpc-1-67-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2161-github-com-cosmwasm-wasmvm-v2-2-1-3.md (0 hunks)
  • .changelog/unreleased/dependencies/2162-cosmossdk-io-api-0-7-6.md (0 hunks)
  • .changelog/unreleased/dependencies/2164-bufbuild-buf-setup-action-1-43-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2165-google-golang-org-grpc-1-67-1.md (0 hunks)
  • .changelog/unreleased/dependencies/2168-bufbuild-buf-setup-action-1-44-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2170-golang-org-x-text-0-19-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2173-google-golang-org-protobuf-1-35-1.md (0 hunks)
  • .changelog/unreleased/dependencies/2174-bufbuild-buf-setup-action-1-45-0.md (0 hunks)
  • .changelog/unreleased/dependencies/2175-bump-sdk-to-50-10.md (0 hunks)
  • .changelog/unreleased/features/2137-bank-scope-value-owners.md (0 hunks)
  • .changelog/unreleased/improvements/2030-explicit-navs.md (0 hunks)
  • .changelog/unreleased/improvements/2062-build-debug.md (0 hunks)
  • .changelog/unreleased/improvements/2112-switch-to-unclog.md (0 hunks)
  • .changelog/unreleased/improvements/2128-marker-nav-docs.md (0 hunks)
  • .changelog/unreleased/improvements/2134-metadata-nav-doc.md (0 hunks)
  • .changelog/unreleased/improvements/2136-makefile-cleanup.md (0 hunks)
  • .changelog/unreleased/improvements/2137-bank-scope-value-owners.md (0 hunks)
  • .changelog/unreleased/improvements/2166-add-changelog-helper.md (0 hunks)
  • .changelog/unreleased/improvements/2176-delete-umber.md (0 hunks)
  • CHANGELOG.md (1 hunks)
  • go.mod (1 hunks)
💤 Files with no reviewable changes (56)
  • .changelog/unreleased/api-breaking/2137-bank-scope-value-owners.md
  • .changelog/unreleased/api-breaking/2176-delete-params.md
  • .changelog/unreleased/bug-fixes/2110-marker-feegrant-fix.md
  • .changelog/unreleased/bug-fixes/2135-openapiv2.md
  • .changelog/unreleased/bug-fixes/2144-remove-metadata-count-telemetry.md
  • .changelog/unreleased/bug-fixes/2177-add-store-telemetry.md
  • .changelog/unreleased/bug-fixes/376-fix-markdown-gen.md
  • .changelog/unreleased/client-breaking/2119-remove-deprecated-bindings.md
  • .changelog/unreleased/client-breaking/2153-keccak.md
  • .changelog/unreleased/client-breaking/2158-fix-metadata-nav-example.md
  • .changelog/unreleased/dependencies/2100-cosmossdk-io-client-v2-2-0-0-beta-4.md
  • .changelog/unreleased/dependencies/2107-cosmossdk-io-core-0-11-1.md
  • .changelog/unreleased/dependencies/2113-cosmossdk-io-x-tx-0-13-4.md
  • .changelog/unreleased/dependencies/2114-github-com-spf13-cast-1-7-0.md
  • .changelog/unreleased/dependencies/2115-golang-org-x-text-0-17-0.md
  • .changelog/unreleased/dependencies/2116-cosmossdk-io-log-1-4-0.md
  • .changelog/unreleased/dependencies/2120-github-com-cometbft-cometbft-0-38-11.md
  • .changelog/unreleased/dependencies/2122-bufbuild-buf-setup-action-1-36-0.md
  • .changelog/unreleased/dependencies/2125-github-com-cosmos-gogoproto-1-7-0.md
  • .changelog/unreleased/dependencies/2126-github-com-cosmwasm-wasmvm-v2-2-1-2.md
  • .changelog/unreleased/dependencies/2129-cosmossdk-io-log-1-4-1.md
  • .changelog/unreleased/dependencies/2130-cosmossdk-io-core-0-11-2.md
  • .changelog/unreleased/dependencies/2131-bufbuild-buf-setup-action-1-37-0.md
  • .changelog/unreleased/dependencies/2132-bump-go-to-1.23.md
  • .changelog/unreleased/dependencies/2133-bufbuild-buf-setup-action-1-38-0.md
  • .changelog/unreleased/dependencies/2138-bufbuild-buf-setup-action-1-39-0.md
  • .changelog/unreleased/dependencies/2141-peter-evans-create-pull-request-7-0-0.md
  • .changelog/unreleased/dependencies/2142-github-com-cometbft-cometbft-0-38-12.md
  • .changelog/unreleased/dependencies/2143-golang-org-x-text-0-18-0.md
  • .changelog/unreleased/dependencies/2150-google-golang-org-grpc-1-66-2.md
  • .changelog/unreleased/dependencies/2151-bufbuild-buf-setup-action-1-41-0.md
  • .changelog/unreleased/dependencies/2152-peter-evans-create-pull-request-7-0-2.md
  • .changelog/unreleased/dependencies/2153-cosmossdk-io-client-v2-2-0-0-beta-5.md
  • .changelog/unreleased/dependencies/2154-cosmossdk-io-x-tx-0-13-5.md
  • .changelog/unreleased/dependencies/2155-bufbuild-buf-setup-action-1-42-0.md
  • .changelog/unreleased/dependencies/2156-peter-evans-create-pull-request-7-0-5.md
  • .changelog/unreleased/dependencies/2157-google-golang-org-grpc-1-67-0.md
  • .changelog/unreleased/dependencies/2161-github-com-cosmwasm-wasmvm-v2-2-1-3.md
  • .changelog/unreleased/dependencies/2162-cosmossdk-io-api-0-7-6.md
  • .changelog/unreleased/dependencies/2164-bufbuild-buf-setup-action-1-43-0.md
  • .changelog/unreleased/dependencies/2165-google-golang-org-grpc-1-67-1.md
  • .changelog/unreleased/dependencies/2168-bufbuild-buf-setup-action-1-44-0.md
  • .changelog/unreleased/dependencies/2170-golang-org-x-text-0-19-0.md
  • .changelog/unreleased/dependencies/2173-google-golang-org-protobuf-1-35-1.md
  • .changelog/unreleased/dependencies/2174-bufbuild-buf-setup-action-1-45-0.md
  • .changelog/unreleased/dependencies/2175-bump-sdk-to-50-10.md
  • .changelog/unreleased/features/2137-bank-scope-value-owners.md
  • .changelog/unreleased/improvements/2030-explicit-navs.md
  • .changelog/unreleased/improvements/2062-build-debug.md
  • .changelog/unreleased/improvements/2112-switch-to-unclog.md
  • .changelog/unreleased/improvements/2128-marker-nav-docs.md
  • .changelog/unreleased/improvements/2134-metadata-nav-doc.md
  • .changelog/unreleased/improvements/2136-makefile-cleanup.md
  • .changelog/unreleased/improvements/2137-bank-scope-value-owners.md
  • .changelog/unreleased/improvements/2166-add-changelog-helper.md
  • .changelog/unreleased/improvements/2176-delete-umber.md
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md

181-181: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (13)
go.mod (2)

25-25: LGTM. Verify compatibility with the updated cosmos-sdk version.

The update of github.com/cosmos/cosmos-sdk from v0.50.7 to v0.50.10 is a minor version increment, which typically includes bug fixes and small improvements. This change follows semantic versioning principles.

To ensure compatibility, please run the following verification steps:

Please review the output of these commands to ensure there are no compatibility issues with the updated cosmos-sdk version.


Line range hint 228-228: Verify fork consistency with the main cosmos-sdk repository.

The replace directive for github.com/cosmos/cosmos-sdk has been updated to match the new version:

github.com/cosmos/cosmos-sdk => github.com/provenance-io/cosmos-sdk v0.50.10-pio-1

This maintains consistency with the main dependency update. However, it's crucial to ensure that the fork is up-to-date with the main repository.

Please run the following commands to verify the fork's consistency:

#!/bin/bash
# Description: Verify fork consistency with the main cosmos-sdk repository

# Test: Compare commit history between main repo and fork
echo "Comparing commit history between main repo and fork..."
git clone https://github.com/cosmos/cosmos-sdk.git cosmos-sdk-main
git clone https://github.com/provenance-io/cosmos-sdk.git cosmos-sdk-fork
cd cosmos-sdk-main
git checkout v0.50.10
MAIN_COMMIT=$(git rev-parse HEAD)
cd ../cosmos-sdk-fork
git checkout v0.50.10-pio-1
FORK_COMMIT=$(git rev-parse HEAD)
echo "Main repo commit: $MAIN_COMMIT"
echo "Fork commit: $FORK_COMMIT"
git log --oneline $MAIN_COMMIT..$FORK_COMMIT

# Test: Check for any additional changes in the fork
echo "Checking for additional changes in the fork..."
git diff $MAIN_COMMIT $FORK_COMMIT

cd ..
rm -rf cosmos-sdk-main cosmos-sdk-fork

Review the output to ensure that any differences between the main repository and the fork are intentional and necessary for your project.

.changelog/prep-release.sh (3)

283-286: LGTM: Improved readability of version validation logic.

The reformatting of the conditional check for sequential minor version numbers enhances code readability without altering the underlying logic. This change is a good example of maintaining clean and easily understandable code.


582-586: LGTM: Crucial improvement for RC handling.

This new logic for handling release candidates (RCs) is a valuable addition to the script. By copying the summary.md file back into the unreleased directory when processing an RC, it ensures that important information is preserved for future releases. The conditional check and error handling are implemented correctly, maintaining consistency with the rest of the script.


Line range hint 1-586: Overall: Significant improvements in RC handling and error management.

The changes made to this script represent a substantial improvement in its functionality, particularly in handling release candidates (RCs) and enhancing error management. Key improvements include:

  1. Better formatting and readability in version validation logic.
  2. Crucial addition of RC-specific handling, ensuring proper preservation of summary information.
  3. Refined error handling throughout the script.

These modifications enhance the script's robustness and reliability in managing the release process, especially for RCs. The changes are well-integrated into the existing structure and maintain consistency with the script's overall style and bash best practices.

CHANGELOG.md (8)

55-56: New release candidate: v1.20.0-rc1

This release candidate introduces several new features, improvements, and bug fixes. It's important to thoroughly test this version before the final release.


61-71: Multiple improvements to existing functionality

Several improvements have been made:

  1. NAV record setting logic change
  2. New build-debug make target
  3. Switch to unclog for changelog entries
  4. Documentation updates for marker and metadata/scope nav commands
  5. Makefile cleanup
  6. Bank module usage for scope value owner tracking
  7. New add-change.sh script for changelog entries
  8. Removal of the umber upgrade

These changes enhance the development process and improve various aspects of the system. Ensure that these changes are well-documented and that any affected workflows are updated accordingly.


179-181: Full commit history provided

The inclusion of the full commit history link is helpful for developers who want to review all changes in detail. This promotes transparency and allows for a more comprehensive understanding of the changes made in this release.

🧰 Tools
🪛 Markdownlint

181-181: null
Bare URL used

(MD034, no-bare-urls)


90-103: API Breaking Changes

Several API breaking changes have been introduced:

  1. Changes to the Ownership query in the x/metadata module
  2. Modifications to the WriteScope endpoint
  3. Changes to MsgWriteScope authorization
  4. Removal of the params module

These changes will require updates to applications interacting with the Provenance blockchain. It's crucial to provide clear documentation and migration guides for these changes. Consider creating a separate document detailing the migration steps for each breaking change.

#!/bin/bash
# Check for the presence of the API breaking changes in the codebase
grep -R "Ownership" x/metadata/
grep -R "WriteScope" x/metadata/
grep -R "MsgWriteScope" x/metadata/
grep -R "params module" .

105-177: Numerous dependency updates

A large number of dependencies have been updated, including:

  • Various bufbuild/buf-setup-action versions
  • cloud.google.com/go/compute/metadata
  • Multiple cosmossdk.io packages
  • github.com/CosmWasm/wasmvm/v2
  • github.com/cometbft/cometbft
  • github.com/cosmos/cosmos-sdk
  • And many others

These updates likely bring performance improvements, bug fixes, and new features from the updated libraries. However, it's important to thoroughly test the system with these new versions to ensure compatibility and stability.

#!/bin/bash
# Check if the go.mod file has been updated with the new versions
grep -E "bufbuild/buf-setup-action|cosmossdk.io|github.com/CosmWasm/wasmvm|github.com/cometbft/cometbft|github.com/cosmos/cosmos-sdk" go.mod

73-79: Bug fixes and improvements

Several important bug fixes have been implemented:

  1. Proto markdown generation and regeneration of proto-docs.md
  2. Restoration of marker funds usage via feegrant
  3. Fix for proto generation
  4. Removal of ineffective telemetry counters from the metadata module
  5. Restoration of telemetry data from cometbft

These fixes address various issues and improve the overall stability and functionality of the system. It's important to verify that these fixes resolve the intended issues without introducing new problems.


81-88: Client Breaking Changes

There are several client breaking changes:

  1. Removal of old provwasm bindings
  2. Change in HashOp enum value in proofs.proto
  3. Correction of metadata nav CLI command example
  4. Addition of volume parameter to NAV entry

These changes may require updates to client applications and documentation. Ensure that these changes are clearly communicated to users and that appropriate migration guides are provided.


57-59: New feature: viridian upgrade

The addition of the viridian upgrade is a significant change. It's crucial to ensure that all necessary upgrade handlers and migrations are in place for this new upgrade.

@SpicyLemon SpicyLemon disabled auto-merge October 15, 2024 23:01
@SpicyLemon SpicyLemon enabled auto-merge (squash) October 15, 2024 23:02
@SpicyLemon SpicyLemon merged commit 035fd5e into main Oct 16, 2024
35 checks passed
@SpicyLemon SpicyLemon deleted the dwedul/v1.20.0-rc1-main branch October 16, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants