Create the (empty) umber-rc2 upgrade. #2069
Conversation
|
Warning Rate limit exceeded@iramiller has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 24 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughRecent updates include adding an empty upgrade entry for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
42-42: Address markdown lint issue: Change dash to asterisk for unordered list style.To maintain consistency with the unordered list style used in the rest of the document, change the dash to an asterisk.
- * Add the (empty) `umber-rc2` upgrade [#2069](https://github.com/provenance-io/provenance/pull/2069). + * Add the (empty) `umber-rc2` upgrade [#2069](https://github.com/provenance-io/provenance/pull/2069).
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- app/upgrades.go (2 hunks)
- app/upgrades_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- app/upgrades.go
Additional context used
Markdownlint
CHANGELOG.md
46-46: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Additional comments not posted (1)
app/upgrades_test.go (1)
405-415: LGTM! Consider adding more comprehensive tests.The function correctly verifies the
umber-rc2upgrade entry. However, consider adding more comprehensive tests to cover future changes.
* Add the umber-rc2 upgrade (which does nothing). * Add changelog entry.
* Add the umber-rc2 upgrade (which does nothing). * Add changelog entry. Co-authored-by: Ira Miller <[email protected]>
Description
This PR creates an empty
umber-rc2upgrade.There is nothing involved in this upgrade, it just gives us a coordinated way to fix the app hash problems.
Of course, it's very possible that something gets added to it before we do it, but for now, it's empty.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
New Features
v1.19.0-rc3and an empty upgrade forumber-rc2.Dependency Updates
github.com/hashicorp/go-getterto a newer version.Tests
umber-rc2upgrade process.