Skip to content

Commit

Permalink
Create the (empty) umber-rc2 upgrade. (#2069)
Browse files Browse the repository at this point in the history
* Add the umber-rc2 upgrade (which does nothing).

* Add changelog entry.
  • Loading branch information
SpicyLemon authored Jul 9, 2024
1 parent 23a2b0b commit d8f0051
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Improvements

* Update all the proto links in the spec docs to point to `v1.19.0` versions of the proto files [#2068](https://github.com/provenance-io/provenance/pull/2068).
* Add the (empty) `umber-rc2` upgrade [#2069](https://github.com/provenance-io/provenance/pull/2069).

### Dependencies

Expand Down
3 changes: 2 additions & 1 deletion app/upgrades.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ type appUpgrade struct {
// If something is happening in the rc upgrade(s) that isn't being applied in the non-rc,
// or vice versa, please add comments explaining why in both entries.
var upgrades = map[string]appUpgrade{
"umber-rc1": { // upgrade for v1.19.0-rc1
"umber-rc1": { // upgrade for v1.19.0-rc2
Added: []string{crisistypes.ModuleName, circuittypes.ModuleName, consensusparamtypes.ModuleName},
Deleted: []string{"reward"},
Handler: func(ctx sdk.Context, app *App, vm module.VersionMap) (module.VersionMap, error) {
Expand Down Expand Up @@ -105,6 +105,7 @@ var upgrades = map[string]appUpgrade{
return vm, nil
},
},
"umber-rc2": {}, // upgrade for v1.19.0-rc3
"umber": { // upgrade for v1.19.0
Added: []string{crisistypes.ModuleName, circuittypes.ModuleName, consensusparamtypes.ModuleName},
Deleted: []string{"reward"},
Expand Down
12 changes: 12 additions & 0 deletions app/upgrades_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,18 @@ func (s *UpgradeTestSuite) TestUmberRC1() {
s.AssertUpgradeHandlerLogs("umber-rc1", expInLog, nil)
}

func (s *UpgradeTestSuite) TestUmberRC2() {
key := "umber-rc2"
s.Assert().Contains(upgrades, key, "%q defined upgrades map", key)

entry := upgrades[key]
s.Assert().NotNil(entry, "%q entry in the upgrades map", key)
s.Assert().Empty(entry.Added, "%q.Added", key)
s.Assert().Empty(entry.Deleted, "%q.Deleted", key)
s.Assert().Empty(entry.Renamed, "%q.Renamed", key)
s.Assert().Nil(entry.Handler, "%q.Handler", key)
}

func (s *UpgradeTestSuite) TestUmber() {
expInLog := []string{
"INF Pruning expired consensus states for IBC.",
Expand Down

0 comments on commit d8f0051

Please sign in to comment.