Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cross-validation): Split time-related results into their own plots #986

Merged
merged 16 commits into from
Dec 20, 2024

Conversation

augustebaum
Copy link
Contributor

@augustebaum augustebaum commented Dec 18, 2024

Closes #902

Screen-record:

2024-12-18T15_00_29_screen_record.mp4
  • fix(cross-validation): Remove "estimator" key even if "indices" is not present
  • feat(cross-validation): Remove times from plot
  • test: Test for CrossValidationItem's plots attribute
  • feat: Group CrossValidationReporter plots into a single attribute
  • feat: Add timing results plot function
  • feat: Integrate timing results plot function to CrossValidationReporter
  • feat: Add normalized timing results plot function
  • feat: Integrate normalized timing results plot function to CrossValidationReporter
  • refactor: Rename plot_cross_validation function
  • refactor: Move cross-validation plots to their own module

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Coverage

pytest coverage report
FileStmtsMissCoverMissing
src/skore
   __init__.py180100% 
   __main__.py811 80%
   exceptions.py40100% 
src/skore/cli
   __init__.py80100% 
   cli.py320100% 
   launch_dashboard.py22120 42%
   quickstart_command.py1220 83%
src/skore/item
   __init__.py210100% 
   cross_validation_item.py127102 92%
   item.py41130 68%
   item_repository.py4221 93%
   media_item.py7041 94%
   numpy_array_item.py2511 93%
   pandas_dataframe_item.py3411 95%
   pandas_series_item.py3411 95%
   polars_dataframe_item.py3211 94%
   polars_series_item.py2711 94%
   primitive_item.py2721 92%
   sklearn_base_estimator_item.py3311 95%
   skrub_table_report_item.py1011 86%
src/skore/persistence
   __init__.py00100% 
   abstract_storage.py2210 95%
   disk_cache_storage.py3311 95%
   in_memory_storage.py200100% 
src/skore/project
   __init__.py40100% 
   create.py5080 88%
   load.py2330 89%
   project.py6244 91%
src/skore/sklearn
   __init__.py30100% 
   find_ml_task.py1923 85%
   types.py20100% 
src/skore/sklearn/cross_validation
   __init__.py20100% 
   cross_validation_helpers.py4141 89%
   cross_validation_reporter.py3711 95%
src/skore/sklearn/cross_validation/plots
   __init__.py00100% 
   compare_scores_plot.py2912 92%
   timing_normalized_plot.py2911 94%
   timing_plot.py2911 94%
src/skore/sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py3421 94%
src/skore/sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py1732 78%
   high_class_imbalance_warning.py1821 88%
   random_state_unset_warning.py1111 87%
   shuffle_true_warning.py901 91%
   stratify_is_set_warning.py1111 87%
   time_based_column_warning.py2212 89%
   train_test_split_warning.py510 80%
src/skore/ui
   __init__.py00100% 
   app.py2552 71%
   dependencies.py710 86%
   project_routes.py500100% 
src/skore/utils
   __init__.py00100% 
   _show_versions.py290100% 
src/skore/view
   __init__.py00100% 
   view.py50100% 
   view_repository.py1621 83%
TOTAL12999991% 

Tests Skipped Failures Errors Time
187 0 💤 0 ❌ 0 🔥 45.560s ⏱️

Copy link
Contributor

@rouk1 rouk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just a few feedbacks.

rouk1
rouk1 previously approved these changes Dec 20, 2024
Copy link
Contributor

@rouk1 rouk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@rouk1 rouk1 merged commit e78610c into main Dec 20, 2024
19 checks passed
@rouk1 rouk1 deleted the 902-split-plots branch December 20, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the CrossValidationReporter plot to have scores in one side, and time on the other side
3 participants