feat: Rename plot to "scores"

probabl-ai · Dec 20, 2024 · 7cf2c5f · 7cf2c5f
1 parent 15bd1d2
commit 7cf2c5f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/skore/src/skore/item/cross_validation_item.py b/skore/src/skore/item/cross_validation_item.py
@@ -154,7 +154,7 @@ def factory(cls, reporter: CrossValidationReporter) -> CrossValidationItem:
         }
 
         humanized_plot_names = {
-            "compare_scores": "Scores",
+            "scores": "Scores",
             "timing": "Timings",
             "timing_normalized": "Normalized timings",
         }

diff --git a/skore/src/skore/sklearn/cross_validation/cross_validation_reporter.py b/skore/src/skore/sklearn/cross_validation/cross_validation_reporter.py
@@ -24,7 +24,7 @@
 class CrossValidationPlots:
     """Plots of the cross-validation results."""
 
-    compare_scores: plotly.graph_objects.Figure
+    scores: plotly.graph_objects.Figure
     timing: plotly.graph_objects.Figure
     timing_normalized: plotly.graph_objects.Figure
 
@@ -187,7 +187,7 @@ def __repr__(self):
     def plots(self) -> CrossValidationPlots:
         """Plots of the cross-validation results."""
         return CrossValidationPlots(
-            compare_scores=plot_cross_validation_compare_scores(self._cv_results),
+            scores=plot_cross_validation_compare_scores(self._cv_results),
             timing=plot_cross_validation_timing(self._cv_results),
             timing_normalized=plot_cross_validation_timing_normalized(self._cv_results),
         )
diff --git a/skore/tests/unit/item/test_cross_validation_item.py b/skore/tests/unit/item/test_cross_validation_item.py
@@ -30,7 +30,7 @@ class FakeCrossValidationReporter:
     X = numpy.array([[1.0]])
     y = numpy.array([1])
     plots = CrossValidationPlots(
-        compare_scores=plotly.graph_objects.Figure(),
+        scores=plotly.graph_objects.Figure(),
         timing=plotly.graph_objects.Figure(),
         timing_normalized=plotly.graph_objects.Figure(),
     )