Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support link variant for migration client #365

Open
wants to merge 2 commits into
base: dani/link-variant
Choose a base branch
from

Conversation

xrutayisire
Copy link
Contributor

@xrutayisire xrutayisire commented Dec 13, 2024

Resolves: DT-2476: AAUser I can use the Migration API client to migrate documents that contain links with variants

Description

  • Remove some TODO that we forgot before
  • Add support for link variant in migration api client

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@xrutayisire xrutayisire marked this pull request as ready for review December 13, 2024 14:25
@xrutayisire xrutayisire requested a review from lihbr December 13, 2024 14:25
@angeloashmore angeloashmore mentioned this pull request Dec 17, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants