Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support link variants #368

Open
wants to merge 2 commits into
base: aa/refactor-link-types
Choose a base branch
from
Open

feat: support link variants #368

wants to merge 2 commits into from
+29 −0

Conversation

angeloashmore
Copy link
Member

@angeloashmore angeloashmore commented Dec 17, 2024 •
edited
Loading

Resolves: #365

Description

This PR re-implements #365 based on #367.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment. ↩

@angeloashmore angeloashmore marked this pull request as ready for review December 17, 2024 02:49
xrutayisire
xrutayisire requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@xrutayisire xrutayisire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ It's missing the update of getOptionalLinkProperties no?

For me, we should always pair text + variant together.
Either we have both or none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrutayisire xrutayisire xrutayisire requested changes

@dani-mp dani-mp dani-mp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angeloashmore @dani-mp @xrutayisire