import eslint config #228
Merged
import eslint config #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vacekj can take over this pr and test the published npm package? |
|
Sure thing @TalDerei |
vacekj
force-pushed
the
eslint-config-prax
branch
from
1d830dd to
28fd143
Compare
|
nit; update eslint path in https://github.com/prax-wallet/prax/blob/main/docs/guiding-principles.md good to merge after eslint package is published to npm and CI passes 👍 |
vacekj
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on penumbra-zone/web#1884
need to also modify the top-level package.json dependency to import the published eslint npm package. cc @vacekj