feat: shared eslint and prettier config #1884
Conversation
🦋 Changeset detectedLatest commit: aa680f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
let’s use prax-wallet/prax#228 as a testing ground before merging.
packages/configs/package.json
Outdated
| "description": "Shared Penumbra configurations", | ||
| "repository": "penumbra-zone/web", | ||
| "type": "module", | ||
| "scripts": {}, |
There was a problem hiding this comment.
our current web <> prax local dev workflow is
web: pnpm install && pnpm build && pnpm dev:pack
web: pnpm dev (separate terminal)
prax: pnpm -w add:tgz ~/PATH_TO_WEB_REPO/web/packages/*/penumbra-zone-*.tgz && pnpm -w syncpack fix-mismatches && pnpm dev
can we update the scripts to include build and pack steps so that the eslint package bundles a .tgz and allows pnpm overrides to watch for changes during prax / dex explorer development? This requires a tsconfig.json.
"scripts": {
"build": "tsc --build --verbose",
"dev:pack": "tsc-watch --onSuccess \"$npm_execpath pack\"",
},
correspondingly, the concurrency settings in the package.json would need to be updated to 17.
There was a problem hiding this comment.
I guess this isn't strictly necessary for dev since we shouldn't expect the eslint / prettier configs to change often.
There was a problem hiding this comment.
I agree that the configs are not expected to change often or dramatically - and they shouldn't, by design. LInts should not get in our way, but rather keep us safe from missteps.
I am testing with prax wallet now.
There was a problem hiding this comment.
are these instructions in a readme anywhere? would be helpful to have in the prax repo
There was a problem hiding this comment.
are these instructions in a readme anywhere? would be helpful to have in the prax repo
we need to clarify these instructions in prax: prax-wallet/prax#149
|
what's the status of this eslint work? was this locally tested against prax-wallet/prax#228? |
this pr adds a package with a shared eslint and prettier configs, to be published to npm
fixes #1762